Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add environment support for kurtosis import #982

Merged
merged 7 commits into from Jul 26, 2023

Conversation

victorcolombo
Copy link
Contributor

@victorcolombo victorcolombo commented Jul 25, 2023

Description:

This PR loads a .env file and renders it in the docker-compose.yml file. This PR notably does not include support for env_file.

Is this change user facing?

YES

References (if applicable):

Closes #981

@victorcolombo victorcolombo enabled auto-merge (squash) July 25, 2023 19:49
@victorcolombo victorcolombo merged commit 24e71d1 into main Jul 26, 2023
29 checks passed
@victorcolombo victorcolombo deleted the vcolombo/env-volumes branch July 26, 2023 01:50
victorcolombo pushed a commit that referenced this pull request Jul 26, 2023
🤖 I have created a release *beep* *boop*
---


##
[0.80.17](0.80.16...0.80.17)
(2023-07-26)


### Features

* Add `environment` support for `kurtosis import`
([#982](#982))
([24e71d1](24e71d1)),
closes [#981](#981)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: kurtosisbot <kurtosisbot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kurtosis import ignores the environment key of Compose
2 participants