Merge pull request #49 from fcastilloes/fix-get-property

Fix default in getProperty()
kusanagi · Jul 12, 2017 · 046724b · 046724b
2 parents 861d441 + 1f7e4c5
commit 046724b
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,6 +5,10 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](http://keepachangelog.com/)
 and this project adheres to [Semantic Versioning](http://semver.org/).
 
+## Upcoming
+## Fixed
+- Fix default property in getProperty()
+
 ## [1.1.6] - 2017-07-10
 ## Fixed
 - Fix meta byte for communicating calls

diff --git a/src/Api/TransportMeta.php b/src/Api/TransportMeta.php
@@ -211,11 +211,12 @@ public function getLevel()
 
     /**
      * @param string $name
-     * @return mixed
+     * @param string $default
+     * @return mixed|string
      */
-    public function getProperty($name)
+    public function getProperty(string $name, string $default = ''): string
     {
-        return $this->properties[$name];
+        return $this->properties[$name] ?: $default;
     }
 
     /**

diff --git a/src/Api/TransportReader.php b/src/Api/TransportReader.php
@@ -72,7 +72,7 @@ public function getOriginDuration(): int
      */
     public function getProperty(string $name, string $default = ''): string
     {
-        return $this->transport->getMeta()->getProperty($name) ?: $default;
+        return $this->transport->getMeta()->getProperty($name, $default);
     }
 
     /**