Test cases for Atomic image. #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtnpro
force-pushed
the
atomic
branch
2 times, most recently
from
3aa43aa
to
c40eef1
Compare
rtnpro
changed the title
|
@kushaldas can you run the tests at your end and verify if it's OK? |
| @unittest.skipUnless(if_atomic(), "It's not an Atomic image") | ||
| class TestDockerStorageSetup(unittest.TestCase): | ||
|
|
||
| def test_journalctl_logs(self): |
There was a problem hiding this comment.
Might be good to include some "known" good output here so anyone reading can get an idea of what the output should look like. This is good for when tests fail and someone tries to go in to see what the test was doing.
There was a problem hiding this comment.
hmm, will do it in the futuire
|
@kushaldas I am done from my side. Please test the changes once. |
kushaldas
added a commit
that referenced
this pull request
Oct 28, 2015
Test cases for Atomic image. Thank you @rtnpro 🍭
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test cases for testing Atomic image.