Print rpm-ostree status #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is explicitly intended to get into the output. |
trishnaguha
requested changes
Feb 15, 2017
atomictests.py
Outdated
| """Print the rpm-ostree status""" | ||
| # We want this explicitly output to stdout | ||
| out, err, eid = system('rpm-ostree status') | ||
| print(out) |
There was a problem hiding this comment.
This is going to print byte string. You may want to convert it into unicode string?
Something similar like out = out.decode('utf-8') before printing the output.
There was a problem hiding this comment.
I don't care about the output type, as long as the actual contents get printed.
kushaldas
reviewed
Feb 21, 2017
| def test_print_status(self): | ||
| """Print the rpm-ostree status""" | ||
| # We want this explicitly output to stdout | ||
| out, err, eid = system('rpm-ostree status') |
There was a problem hiding this comment.
Can you please add this in the next line? and then do the print
out = out.decode('utf-8')
puiterwijk
force-pushed
the
printatomic
branch
from
66f93ee
to
a0a1c45
Compare
Signed-off-by: Patrick Uiterwijk <puiterwijk@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Patrick Uiterwijk puiterwijk@redhat.com