Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node PluginName vs DisplayName is Hacky #109

Closed
4 of 6 tasks
mfisher31 opened this issue Nov 6, 2019 · 0 comments
Closed
4 of 6 tasks

Node PluginName vs DisplayName is Hacky #109

mfisher31 opened this issue Nov 6, 2019 · 0 comments
Labels
techdebt Technical debt
Milestone
0.47.x

Comments

@mfisher31
Copy link
Member

mfisher31 commented Nov 6, 2019 •
edited
Loading

Code for refreshing actual plugin name and display name is not concise. This needs cleaned up ASAP before dealing with node names in the future.

  • GraphNode - should have a way to refresh display name.
  • GraphNode - Specialize main Audio/MIDI IO nodes if needed.
  • AudioEngine - should refresh Root level IO nodes when device changes.
  • GraphEditor - Needs some housekeeping when determining title/sub-title text
  • MIDI device node names cause annoying assertions
  • Anything else which is workaround-y

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.
@mfisher31 mfisher31 added the techdebt Technical debt label Nov 6, 2019
@mfisher31 mfisher31 added this to the 0.43.0 milestone Nov 6, 2019
@mfisher31 mfisher31 self-assigned this Nov 22, 2019
@mfisher31 mfisher31 modified the milestones: 0.43.0, 0.44.0 Jan 31, 2020
@mfisher31 mfisher31 modified the milestones: 0.44.0, 0.45.0, 1.0.0 Jun 6, 2020
@mfisher31 mfisher31 modified the milestones: 1.0.0, 0.47.x Mar 22, 2021
@mfisher31 mfisher31 removed their assignment Mar 24, 2021
mfisher31 added a commit that referenced this issue Apr 16, 2021
@mfisher31
Make sure IONode gets a name. Fixes #109
38318f9
mfisher31 added a commit that referenced this issue Apr 17, 2021
@mfisher31
Don't display no device title when running as plugin. Closes #109
19610e4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
techdebt Technical debt
Projects
None yet
Milestone
0.47.x
Development

No branches or pull requests
1 participant
@mfisher31