Toggle menu #9
Toggle menu #9
Conversation
- it adds toggle menu with javascript
There was a problem hiding this comment.
Hi @kusiLaw ,
Your project is complete! There is nothing else to say other than... it's time to merge it 
Congratulations! 🎉
Highlights
- No linter errors ✔️
- Menu working fine ✔️
- Used project requirements well ✔️
Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
| const toggleBtnContainer = createMyElement('div', 'close-button-container'); | ||
| const toggleBtn = createMyElement('img', 'img-close'); | ||
| toggleBtn.setAttribute('src', './../images/x.svg'); | ||
| toggleBtnContainer.appendChild(toggleBtn); | ||
| container.appendChild(toggleBtnContainer); |
There was a problem hiding this comment.
- [OPTIONAL] Good job so far! Please fix the error of
Xicon in the picture because it is not showing for me maybe it is my mistake. - Please, if you have this icon, leave a screenshot of the menu
Xicon under this suggestion.
There was a problem hiding this comment.
Thank you very much Muhammad Rizo.
You are right. It works fine here on my laptop and phone, but I think for it to work generally, I should count the path from the root, instead of the js folder. Now fixed. thank you
This pull request adds a toggle menu to the portfolio mobile version with the following functionality