Use upstream libui-node

[mischnic]

The upstream libui-node master should now equal your fork ($ORIGIN rpath on linux and copying nbind.node to the root folder), but it also sets the rpath correctly for macOS.

proton-native/package.json

Line 36 in 7741dd2

"libui-node": "kusti8/libui-node",

[kusti8]

Ok looks good. Did you increment the version a d publish to npm because I didn't see that in your diffs.

[mischnic]

@parro-it ?

[parro-it]

Just released 0.1.0 on npm.
I'm testing now with my fork of proton... I will publish a PR here.

[mischnic]

@parro-it This can get you started: mischnic@d42ab2b

[parro-it]

Oh great! if you open a PR here of your forks I'll push further changes there (I don't know if I need specific permission to do so)

[kusti8]

Does libui not need to be initialized anymore ? I noticed that was taken out in the fork.

[parro-it]

Any idea why I get Electron installed when I npm install proton?

Electron is not a direct proton dependency AFAIK

[parro-it]

Does libui not need to be initialized anymore ? I noticed that was taken out in the fork.

No, init is now called automatically the first time you require the module. We'll have to update docs & examples

[mischnic]

Not of proton, but the react dev tools:

proton-native/package.json

Line 50 in 57896ff

"react-devtools": "^3.0.0"

@kusti8 How does integration with the dev tools work? This doesn't:

proton-native/src/render/index.js

Lines 17 to 22 in e10f481

	// DesktopRenderer.injectIntoDevTools({
	// bundleType: 1,
	// version: '0.1.0',
	// rendererPackageName: 'custom-renderer',
	// findHostInstanceByFiber: DesktopRenderer.findHostInstance
	// })

PR: #57

[kusti8]

I used to use the dev tools to debug some of the code that wasn't working. It isn't strictly necessary anymore.

…

On Mon, Mar 19, 2018, 2:49 PM Niklas Mischkulnig ***@***.***> wrote: Not of proton, but the react dev tools: https://github.com/kusti8/proton-native/blob/57896ffed96188a40328b4239858a110f395b1f6/package.json#L50 @kusti8 <https://github.com/kusti8> How does integration with the dev tools work? This doesn't: https://github.com/kusti8/proton-native/blob/e10f4818611e7f61261865678e127cd6bd56c3c8/src/render/index.js#L17-L22 PR: #57 <#57> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#54 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AJW73Gl2e2rQuRtZamUOw0Cmq69eqrxCks5tf_3HgaJpZM4Ss9ur> .

[mischnic]

I tried commenting out these lines and the dev tools started by npx react-dev-tool didn't connect to proton.

[parro-it]

It's working 🎉

@mischnic I pushed to your fork