Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows10 環境で PatchSerializerTest が失敗するバグを修正 #798

Merged
merged 6 commits into from Nov 12, 2020
Merged

Windows10 環境で PatchSerializerTest が失敗するバグを修正 #798

merged 6 commits into from Nov 12, 2020

Conversation

ty-v1
Copy link
Contributor

@ty-v1 ty-v1 commented Oct 28, 2020 •
edited

resolve #797

原因

実行環境の文字コードがUTF-8以外かつマルチバイト文字が修正対象に含まれるときに，ASTの操作に失敗するため．

変更点

  • ASTを作るときに読み込むソースコードのエンコーディングを渡すようにした．
  • ソースコードをUTF-8に変換せずにそのまま保持するようにした.

TODO

  • windows環境での動作確認
  • テストを書く

@clione-bot
Copy link

clione-bot bot commented Oct 28, 2020

No problem. Good job!

@ty-v1 ty-v1 changed the title [WIP] Windows10 環境で PatchSerializerTest が失敗するバグを修正 Windows10 環境で PatchSerializerTest が失敗するバグを修正 Nov 9, 2020
@ty-v1 ty-v1 requested a review from hrtwt November 9, 2020 08:54
hrtwt
hrtwt requested changes Nov 12, 2020
View reviewed changes
Copy link
Contributor

@hrtwt hrtwt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2点コメントさせていただきました．
どちらも unused import の削除です．
修正よろしくお願いします．

src/main/java/jp/kusumotolab/kgenprog/output/FileDiff.java Show resolved Hide resolved
src/main/java/jp/kusumotolab/kgenprog/project/jdt/JDTASTConstruction.java Show resolved Hide resolved
@ty-v1
Copy link
Contributor Author

ty-v1 commented Nov 12, 2020

修正しました

hrtwt
hrtwt approved these changes Nov 12, 2020
View reviewed changes
Copy link
Contributor

@hrtwt hrtwt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

修正ありがとうございます．
問題ないように思いますのでマージします．
お疲れさまでした．

@hrtwt hrtwt merged commit 9223ac8 into master Nov 12, 2020
@hrtwt hrtwt deleted the fix-ast-encoding-bug branch November 12, 2020 11:26
@shinsuke-mat shinsuke-mat mentioned this pull request Dec 2, 2020
Closed
@hnymA hnymA mentioned this pull request Dec 2, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hrtwt hrtwt hrtwt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

一部の Windows10 環境で PatchSerializerTest に失敗する
2 participants
@ty-v1 @hrtwt