New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JSON出力周りのリファクタリング #819
JSON出力周りのリファクタリング #819
Conversation
No problem. Good job! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
細かい点が多いですがコメント付けました.直接確認した箇所もメモとして残してあります.
src/main/java/jp/kusumotolab/kgenprog/project/test/TestResults.java
Outdated
Show resolved
Hide resolved
src/main/java/jp/kusumotolab/kgenprog/project/test/TestResults.java
Outdated
Show resolved
Hide resolved
src/main/java/jp/kusumotolab/kgenprog/output/FileDiffSerializer.java
Outdated
Show resolved
Hide resolved
src/test/java/jp/kusumotolab/kgenprog/output/CrossoverHistoricalElementSerializerTest.java
Outdated
Show resolved
Hide resolved
src/test/java/jp/kusumotolab/kgenprog/output/MutationHistoricalElementSerializerTest.java
Outdated
Show resolved
Hide resolved
src/test/java/jp/kusumotolab/kgenprog/output/HistoricalElementSerializerTest.java
Outdated
Show resolved
Hide resolved
src/test/java/jp/kusumotolab/kgenprog/output/VariantSerializerTest.java
Outdated
Show resolved
Hide resolved
src/test/java/jp/kusumotolab/kgenprog/project/test/TestResultsTest.java
Outdated
Show resolved
Hide resolved
…lizers # Conflicts: # src/main/java/jp/kusumotolab/kgenprog/project/test/TestResults.java
@tt-kuma |
このPRのいけてないところをIssueにする. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3/18mtgで決定した通り,軽めのレビューをしました.
特に問題はなさそうなのでマージします.
お疲れさまでした.
resolve #511
やったこと
カスタムシリアライザのリファクタリング
下のような1つ1つkeyとvalueを指定している部分を極力消した.
kGenProg/src/main/java/jp/kusumotolab/kgenprog/output/VariantSerializer.java
Lines 104 to 114 in 32f06b8
デバッグ用のjsonシリアライザ処理のリファクタリング.Gsonを使うようにした
kGenProg/src/main/java/jp/kusumotolab/kgenprog/project/test/TestResults.java
Lines 251 to 267 in 32f06b8