[1.x] Add support for setting badge count on iOS #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gentritabazi
changed the title
Comment on lines
+143
to
+148
| if (isset($this->badgeCount)) { | ||
| $fields['notification']['badge'] = $this->badgeCount; | ||
| } | ||
| if (isset($this->contentAvailable)) { | ||
| $fields['notification']['content_available'] = $this->contentAvailable; | ||
| } |
There was a problem hiding this comment.
Suggested change
| if (isset($this->badgeCount)) { | |
| $fields['notification']['badge'] = $this->badgeCount; | |
| } | |
| if (isset($this->contentAvailable)) { | |
| $fields['notification']['content_available'] = $this->contentAvailable; | |
| } | |
| if (isset($this->badgeCount)) { | |
| $fields['notification']['badge'] = $this->badgeCount; | |
| } | |
| if (isset($this->contentAvailable)) { | |
| $fields['notification']['content_available'] = $this->contentAvailable; | |
| } | |
|
@lagerroos Thanks for your contribution. Can you also add documentation to the README file? |
|
I just saw that the 2 methods are only for IOS, so it makes sense to use https://firebase.google.com/docs/cloud-messaging/http-server-ref |
|
@gentritabazi01 But unfortunately it does not work from |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows the user to attach a badge count, in other words, the number of unread notifications on an app icon. It also allows sending background updates through Firebase, e.g. to wake up the app from a sleeping state.