Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom attributes #5

Merged
merged 6 commits into from Oct 5, 2017
Merged

Custom attributes #5

merged 6 commits into from Oct 5, 2017

Conversation

greggb
Copy link
Contributor

@greggb greggb commented Oct 5, 2017

This is a handy plugin. I use a couple of different attrs to test that would be nice to remove, so I thought it would be a good option to pass in.

state.opts is always an empty object if nothing is passed in.

@coveralls
Copy link

coveralls commented Oct 5, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 02366d0 on greggb:custom-attributes into 3ca3730 on kutyel:master.

@kutyel
Copy link
Owner

kutyel commented Oct 5, 2017

Hi, first of all, thank you very much for your PR!

Initially I didn't want to merge this because there is already another plugin to remove any attribute, even though it is not very used I didn't want to duplicate plugins.

I think the differentiating factor between both is the default case, data-test-id which seems to be pretty common, and the fact that without configuring the plugin you can just drop it and it starts working. Also, the naming of the plugin is quite representative which I think is something in my favour 😉

I'm merging it with some changes to the code because I think either way having the ability to customize something is always great! 👍

@coveralls
Copy link

coveralls commented Oct 5, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling dd82c07 on greggb:custom-attributes into 3ca3730 on kutyel:master.

@coveralls
Copy link

coveralls commented Oct 5, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 039b67e on greggb:custom-attributes into 3ca3730 on kutyel:master.

@kutyel kutyel merged commit 015da34 into kutyel:master Oct 5, 2017
@greggb
Copy link
Contributor Author

greggb commented Oct 5, 2017

No worries. Thanks for pulling it in!

@greggb greggb deleted the custom-attributes branch October 5, 2017 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants