Fix Windows Script Issues #70
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
mattigrthr
requested changes
Jan 13, 2022
|
As the result of my discussion with @mattigrthr here, we decided to use new approach to the problem by companying shell script entirely with Python script, so those who cannot run a shell script, can use the python script as an alternative. |
|
Branch conflicts with #71 resolved |
mattigrthr
requested changes
Jan 26, 2022
Closed
|
Closing this PR as we replaced the setup scripts with pre-built Docker images and improved documentation for the local Python setup of the CLI (including Windows). The Dockerization of the CLI that would simplify the setup further is in a separate issue #101. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, I wanted to add a little fix in 'Windows run-able' script generated by
initialize_windows.shby adding some extracd ..in the second line of each script that needs to be outside of/scriptsfolder.