Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bind timeout function for Node.js APIs #2311

Merged
merged 3 commits into from
Oct 31, 2023
Merged

Bind timeout function for Node.js APIs #2311

merged 3 commits into from
Oct 31, 2023

Conversation

mewim
Copy link
Collaborator

@mewim mewim commented Oct 31, 2023

No description provided.

@mewim mewim changed the title Bind timeout functions for Node.js APIs Bind timeout function for Node.js APIs Oct 31, 2023
@codecov
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (2021979) 89.82% compared to head (8dd4288) 89.81%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2311      +/-   ##
==========================================
- Coverage   89.82%   89.81%   -0.01%     
==========================================
  Files        1023     1023              
  Lines       35439    35447       +8     
==========================================
+ Hits        31832    31837       +5     
- Misses       3607     3610       +3     
Files Coverage Δ
src/include/storage/storage_info.h 100.00% <100.00%> (ø)
tools/nodejs_api/src_cpp/include/node_connection.h 90.47% <ø> (+4.76%) ⬆️
tools/nodejs_api/src_cpp/node_connection.cpp 88.23% <62.50%> (-4.79%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mewim mewim merged commit 43128fc into master Oct 31, 2023
11 of 12 checks passed
@mewim mewim deleted the nodejs-timeout-bind branch October 31, 2023 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants