Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support Cast(String, FixedList Type) #2369

Merged
merged 1 commit into from
Nov 8, 2023
Merged

Conversation

AEsir777
Copy link
Collaborator

@AEsir777 AEsir777 commented Nov 7, 2023

  • fix error msg
  • complete cast(item, "INT64[4]")

@AEsir777 AEsir777 marked this pull request as ready for review November 7, 2023 23:24
@AEsir777 AEsir777 force-pushed the explicit-cast-nested branch 2 times, most recently from 4b1332c to a79ac31 Compare November 7, 2023 23:29
Copy link

codecov bot commented Nov 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9ab52f6) 90.79% compared to head (4a7fb80) 90.89%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2369      +/-   ##
==========================================
+ Coverage   90.79%   90.89%   +0.10%     
==========================================
  Files        1015     1015              
  Lines       35732    35811      +79     
==========================================
+ Hits        32444    32552     +108     
+ Misses       3288     3259      -29     
Files Coverage Δ
src/common/vector/value_vector.cpp 100.00% <100.00%> (+5.42%) ⬆️
src/function/cast_string_to_functions.cpp 99.75% <100.00%> (+<0.01%) ⬆️
src/function/vector_cast_functions.cpp 95.51% <100.00%> (+0.57%) ⬆️
src/include/common/vector/value_vector.h 100.00% <ø> (ø)
...function/cast/functions/cast_string_to_functions.h 100.00% <ø> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/common/vector/value_vector.cpp Outdated Show resolved Hide resolved
src/function/vector_cast_functions.cpp Outdated Show resolved Hide resolved
src/function/vector_cast_functions.cpp Outdated Show resolved Hide resolved
@AEsir777 AEsir777 force-pushed the explicit-cast-nested branch 7 times, most recently from 53440c9 to bb72054 Compare November 8, 2023 19:59
@AEsir777 AEsir777 changed the title support Cast String to FixedList support Cast(String, FixedList Type) Nov 8, 2023
@AEsir777 AEsir777 merged commit fd388b4 into master Nov 8, 2023
12 checks passed
@AEsir777 AEsir777 deleted the explicit-cast-nested branch November 8, 2023 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants