Commits on Nov 17, 2023

1. prepared_statement: move parameters …

   In the Java API, we had a bug where we take ownership of and free
   parameters passed into executeWithParams.
   
   Inspecting the method itself, it was taking a shared_ptr, but then
   performing a deep copy, which is nonsense. Instead, we should take a
   unique_ptr, since we need to copy the parameters to guarantee that they
   are not modified for the duration of the query.
   
   This commit also fixes three other issues. First, the Java tests weren't running
   any tests from ConnectionTest.java, which is why we didn't observe this
   bug. Additionally, the constructor of KuzuConnection uses an assertion,
   but assertions are disabled by default, which causes our tests to fail
   (and if the assertion is skipped, we segfault).
   
   Also, since rust-lang/cc-rs#900 has been
   fixed, we can remove the version pinning of `cc` on MacOS.

   

   Riolku committed Nov 17, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for 63baff5
   • Browse repository at this point

   Copy the full SHA

   63baff5 View commit details

   Browse the repository at this point in the history