Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detach delete #2453

Merged
merged 1 commit into from
Nov 19, 2023
Merged

Detach delete #2453

merged 1 commit into from
Nov 19, 2023

Conversation

ray6080
Copy link
Contributor

@ray6080 ray6080 commented Nov 19, 2023

No description provided.

Copy link

codecov bot commented Nov 19, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (bd4f0e2) 91.40% compared to head (fc4a49a) 91.41%.

Files Patch % Lines
...e/binder/query/updating_clause/bound_delete_info.h 50.00% 2 Missing ⚠️
src/common/enums/rel_direction.cpp 80.00% 1 Missing ⚠️
...clude/parser/query/updating_clause/delete_clause.h 66.66% 1 Missing ⚠️
src/planner/operator/persistent/logical_delete.cpp 88.88% 1 Missing ⚠️
.../processor/operator/persistent/delete_executor.cpp 94.73% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2453   +/-   ##
=======================================
  Coverage   91.40%   91.41%           
=======================================
  Files        1023     1024    +1     
  Lines       37351    37438   +87     
=======================================
+ Hits        34142    34225   +83     
- Misses       3209     3213    +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ray6080 ray6080 merged commit 53772d3 into master Nov 19, 2023
12 checks passed
@ray6080 ray6080 deleted the detach-delete branch November 19, 2023 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants