kuzudb · Riolku · Nov 28, 2023 · Nov 27, 2023
diff --git a/.clang-tidy b/.clang-tidy
@@ -18,6 +18,9 @@ Checks:
 
   modernize-use-override,
 
+  performance-*,
+  -performance-no-int-to-ptr,
+
 HeaderFilterRegex:
   src/include|tools/benchmark/include|tools/nodejs_api/src_cpp/include|tools/python_api/src_cpp/include|tools/rust_api/include|tools/shell/include
 WarningsAsErrors: "*"
diff --git a/src/binder/bind/bind_ddl.cpp b/src/binder/bind/bind_ddl.cpp
@@ -20,7 +20,7 @@ namespace kuzu {
 namespace binder {
 
 std::vector<std::unique_ptr<Property>> Binder::bindProperties(
-    std::vector<std::pair<std::string, std::string>> propertyNameDataTypes) {
+    const std::vector<std::pair<std::string, std::string>>& propertyNameDataTypes) {
     std::vector<std::unique_ptr<Property>> boundPropertyNameDataTypes;
     std::unordered_set<std::string> boundPropertyNames;
     boundPropertyNames.reserve(propertyNameDataTypes.size());
@@ -135,7 +135,11 @@ std::unique_ptr<BoundCreateTableInfo> Binder::bindCreateRelTableGroupInfo(
     auto relMultiplicity = extraInfo->relMultiplicity;
     std::vector<std::unique_ptr<BoundCreateTableInfo>> boundCreateRelTableInfos;
     for (auto& [srcTableName, dstTableName] : extraInfo->srcDstTablePairs) {
-        auto relTableName = relGroupName + "_" + srcTableName + "_" + dstTableName;
+        auto relTableName = std::string(relGroupName)
+                                .append("_")
+                                .append(srcTableName)
+                                .append("_")
+                                .append(dstTableName);
         auto relExtraInfo =
             std::make_unique<ExtraCreateRelTableInfo>(relMultiplicity, srcTableName, dstTableName);
         auto relCreateInfo = std::make_unique<CreateTableInfo>(

diff --git a/src/binder/bind/bind_reading_clause.cpp b/src/binder/bind/bind_reading_clause.cpp
@@ -124,7 +124,7 @@ std::unique_ptr<BoundReadingClause> Binder::bindInQueryCall(const ReadingClause&
     }
     // TODO: this is dangerous because we could match to a scan function.
     auto tableFunction = reinterpret_cast<function::TableFunction*>(
-        catalog.getBuiltInFunctions()->matchScalarFunction(std::move(funcName), inputTypes));
+        catalog.getBuiltInFunctions()->matchScalarFunction(funcName, inputTypes));
     auto bindInput = std::make_unique<function::TableFuncBindInput>();
     bindInput->inputs = std::move(inputValues);
     auto bindData =
@@ -136,7 +136,7 @@ std::unique_ptr<BoundReadingClause> Binder::bindInQueryCall(const ReadingClause&
     auto offset = expressionBinder.createVariableExpression(
         *LogicalType::INT64(), std::string(InternalKeyword::ROW_OFFSET));
     auto boundInQueryCall = std::make_unique<BoundInQueryCall>(
-        std::move(tableFunction), std::move(bindData), std::move(columns), offset);
+        tableFunction, std::move(bindData), std::move(columns), offset);
     if (call.hasWherePredicate()) {
         auto wherePredicate = expressionBinder.bindExpression(*call.getWherePredicate());
         boundInQueryCall->setWherePredicate(std::move(wherePredicate));

diff --git a/src/binder/bind/copy/bind_copy_rdf_graph.cpp b/src/binder/bind/copy/bind_copy_rdf_graph.cpp
@@ -59,6 +59,7 @@ std::unique_ptr<BoundStatement> Binder::bindCopyRdfRelFrom(const Statement& /*st
     columnNames.emplace_back(rdf::PID);
     columnNames.emplace_back(InternalKeyword::DST_OFFSET);
     std::vector<std::unique_ptr<common::LogicalType>> columnTypes;
+    columnTypes.reserve(3);
     for (auto i = 0u; i < 3; ++i) {
         columnTypes.push_back(LogicalType::INT64());
     }

diff --git a/src/binder/bind_expression/bind_comparison_expression.cpp b/src/binder/bind_expression/bind_comparison_expression.cpp
@@ -15,7 +15,7 @@ std::shared_ptr<Expression> ExpressionBinder::bindComparisonExpression(
         auto child = bindExpression(*parsedExpression.getChild(i));
         children.push_back(std::move(child));
     }
-    return bindComparisonExpression(parsedExpression.getExpressionType(), std::move(children));
+    return bindComparisonExpression(parsedExpression.getExpressionType(), children);
 }
 
 std::shared_ptr<Expression> ExpressionBinder::bindComparisonExpression(

diff --git a/src/binder/bind_expression/bind_function_expression.cpp b/src/binder/bind_expression/bind_function_expression.cpp
@@ -183,7 +183,7 @@ std::unique_ptr<Expression> ExpressionBinder::createInternalNodeIDExpression(
 }
 
 std::shared_ptr<Expression> ExpressionBinder::bindInternalIDExpression(
-    std::shared_ptr<Expression> expression) {
+    const std::shared_ptr<Expression>& expression) {
     if (ExpressionUtil::isNodePattern(*expression)) {
         auto& node = (NodeExpression&)*expression;
         return node.getInternalID();

diff --git a/src/binder/bind_expression/bind_property_expression.cpp b/src/binder/bind_expression/bind_property_expression.cpp
@@ -51,7 +51,7 @@ expression_vector ExpressionBinder::bindNodeOrRelPropertyStarExpression(const Ex
 }
 
 expression_vector ExpressionBinder::bindStructPropertyStarExpression(
-    std::shared_ptr<Expression> child) {
+    const std::shared_ptr<Expression>& child) {
     expression_vector result;
     auto childType = child->getDataType();
     for (auto field : StructType::getFields(&childType)) {

diff --git a/src/binder/binder.cpp b/src/binder/binder.cpp
@@ -220,17 +220,14 @@ function::TableFunction* Binder::getScanFunction(common::FileType fileType, bool
             catalog.getBuiltInFunctions()->matchScalarFunction(READ_PARQUET_FUNC_NAME, inputTypes);
     } break;
     case common::FileType::NPY: {
-        func = catalog.getBuiltInFunctions()->matchScalarFunction(
-            READ_NPY_FUNC_NAME, std::move(inputTypes));
+        func = catalog.getBuiltInFunctions()->matchScalarFunction(READ_NPY_FUNC_NAME, inputTypes);
     } break;
     case common::FileType::CSV: {
         func = catalog.getBuiltInFunctions()->matchScalarFunction(
-            isParallel ? READ_CSV_PARALLEL_FUNC_NAME : READ_CSV_SERIAL_FUNC_NAME,
-            std::move(inputTypes));
+            isParallel ? READ_CSV_PARALLEL_FUNC_NAME : READ_CSV_SERIAL_FUNC_NAME, inputTypes);
     } break;
     case common::FileType::TURTLE: {
-        func = catalog.getBuiltInFunctions()->matchScalarFunction(
-            READ_RDF_FUNC_NAME, std::move(inputTypes));
+        func = catalog.getBuiltInFunctions()->matchScalarFunction(READ_RDF_FUNC_NAME, inputTypes);
     } break;
     default:
         KU_UNREACHABLE;

diff --git a/src/binder/bound_statement_result.cpp b/src/binder/bound_statement_result.cpp
@@ -8,7 +8,7 @@ namespace kuzu {
 namespace binder {
 
 std::unique_ptr<BoundStatementResult> BoundStatementResult::createSingleStringColumnResult(
-    std::string columnName) {
+    const std::string& columnName) {
     auto result = std::make_unique<BoundStatementResult>();
     auto value = std::make_unique<Value>(LogicalType{LogicalTypeID::STRING}, columnName);
     auto stringColumn = std::make_shared<LiteralExpression>(std::move(value), columnName);

diff --git a/src/binder/expression_binder.cpp b/src/binder/expression_binder.cpp
@@ -58,7 +58,7 @@ std::shared_ptr<Expression> ExpressionBinder::bindExpression(
 }
 
 std::shared_ptr<Expression> ExpressionBinder::foldExpression(
-    std::shared_ptr<Expression> expression) {
+    const std::shared_ptr<Expression>& expression) {
     auto value = evaluator::ExpressionEvaluatorUtils::evaluateConstantExpression(
         expression, binder->memoryManager);
     auto result = createLiteralExpression(std::move(value));

diff --git a/src/binder/query/query_graph.cpp b/src/binder/query/query_graph.cpp
@@ -151,13 +151,13 @@ void QueryGraph::addQueryNode(std::shared_ptr<NodeExpression> queryNode) {
         return;
     }
     queryNodeNameToPosMap.insert({queryNode->getUniqueName(), queryNodes.size()});
-    queryNodes.push_back(queryNode);
+    queryNodes.push_back(std::move(queryNode));
 }
 
 void QueryGraph::addQueryRel(std::shared_ptr<RelExpression> queryRel) {
     KU_ASSERT(!containsQueryRel(queryRel->getUniqueName()));
     queryRelNameToPosMap.insert({queryRel->getUniqueName(), queryRels.size()});
-    queryRels.push_back(queryRel);
+    queryRels.push_back(std::move(queryRel));
 }
 
 void QueryGraph::merge(const QueryGraph& other) {
@@ -230,8 +230,8 @@ std::unique_ptr<QueryGraphCollection> QueryGraphCollection::copy() const {
     return result;
 }
 
-void PropertyKeyValCollection::addKeyVal(
-    std::shared_ptr<Expression> variable, const std::string& propertyName, expression_pair keyVal) {
+void PropertyKeyValCollection::addKeyVal(const std::shared_ptr<Expression>& variable,
+    const std::string& propertyName, expression_pair keyVal) {
     if (!propertyKeyValMap.contains(variable)) {
         propertyKeyValMap.insert({variable, std::unordered_map<std::string, expression_pair>{}});
     }
@@ -249,7 +249,7 @@ std::vector<expression_pair> PropertyKeyValCollection::getKeyVals() const {
 }
 
 std::vector<expression_pair> PropertyKeyValCollection::getKeyVals(
-    std::shared_ptr<Expression> variable) const {
+    const std::shared_ptr<Expression>& variable) const {
     std::vector<expression_pair> result;
     if (!propertyKeyValMap.contains(variable)) {
         return result;
@@ -261,7 +261,7 @@ std::vector<expression_pair> PropertyKeyValCollection::getKeyVals(
 }
 
 bool PropertyKeyValCollection::hasKeyVal(
-    std::shared_ptr<Expression> variable, const std::string& propertyName) const {
+    const std::shared_ptr<Expression>& variable, const std::string& propertyName) const {
     if (!propertyKeyValMap.contains(variable)) {
         return false;
     }
@@ -272,7 +272,7 @@ bool PropertyKeyValCollection::hasKeyVal(
 }
 
 expression_pair PropertyKeyValCollection::getKeyVal(
-    std::shared_ptr<Expression> variable, const std::string& propertyName) const {
+    const std::shared_ptr<Expression>& variable, const std::string& propertyName) const {
     KU_ASSERT(hasKeyVal(variable, propertyName));
     return propertyKeyValMap.at(variable).at(propertyName);
 }

diff --git a/src/catalog/catalog_content.cpp b/src/catalog/catalog_content.cpp
@@ -128,6 +128,7 @@ table_id_t CatalogContent::addRdfGraphSchema(const BoundCreateTableInfo& info) {
 
 std::vector<TableSchema*> CatalogContent::getTableSchemas() const {
     std::vector<TableSchema*> result;
+    result.reserve(tableSchemas.size());
     for (auto&& [_, schema] : tableSchemas) {
         result.push_back(schema.get());
     }

diff --git a/src/common/types/int128_t.cpp b/src/common/types/int128_t.cpp
@@ -118,7 +118,7 @@ std::string Int128_t::ToString(int128_t input) {
             break;
         }
         input = divModPositive(input, 10, remainder);
-        result = std::string(1, '0' + remainder) + result;
+        result = std::string(1, '0' + remainder) + std::move(result);
     }
     if (result.empty()) {
         result = "0";

diff --git a/src/common/types/types.cpp b/src/common/types/types.cpp
@@ -274,10 +274,6 @@ LogicalType::LogicalType(const LogicalType& other) {
     }
 }
 
-LogicalType::LogicalType(LogicalType&& other) noexcept
-    : typeID{other.typeID}, physicalType{other.physicalType}, extraTypeInfo{
-                                                                  std::move(other.extraTypeInfo)} {}
-
 LogicalType& LogicalType::operator=(const LogicalType& other) {
     typeID = other.typeID;
     physicalType = other.physicalType;
@@ -310,13 +306,6 @@ bool LogicalType::operator!=(const LogicalType& other) const {
     return !((*this) == other);
 }
 
-LogicalType& LogicalType::operator=(LogicalType&& other) noexcept {
-    typeID = other.typeID;
-    physicalType = other.physicalType;
-    extraTypeInfo = std::move(other.extraTypeInfo);
-    return *this;
-}
-
 std::string LogicalType::toString() const {
     switch (typeID) {
     case LogicalTypeID::MAP: {
@@ -660,6 +649,7 @@ std::string LogicalTypeUtils::toString(LogicalTypeID dataTypeID) {
 
 std::string LogicalTypeUtils::toString(const std::vector<LogicalType*>& dataTypes) {
     std::vector<LogicalTypeID> dataTypeIDs;
+    dataTypeIDs.reserve(dataTypes.size());
     for (auto& dataType : dataTypes) {
         dataTypeIDs.push_back(dataType->typeID);
     }

diff --git a/src/common/types/value/value.cpp b/src/common/types/value/value.cpp
@@ -1,5 +1,7 @@
 #include "common/types/value/value.h"
 
+#include <utility>
+
 #include "common/null_buffer.h"
 #include "common/serializer/deserializer.h"
 #include "common/serializer/serializer.h"
@@ -40,8 +42,8 @@ Value Value::createNullValue() {
     return {};
 }
 
-Value Value::createNullValue(LogicalType dataType) {
-    return Value(std::move(dataType));
+Value Value::createNullValue(const LogicalType& dataType) {
+    return Value(dataType);
 }
 
 Value Value::createDefaultValue(const LogicalType& dataType) {
@@ -86,7 +88,9 @@ Value Value::createDefaultValue(const LogicalType& dataType) {
     case LogicalTypeID::FIXED_LIST: {
         std::vector<std::unique_ptr<Value>> children;
         auto childType = FixedListType::getChildType(&dataType);
-        for (auto i = 0u; i < FixedListType::getNumValuesInList(&dataType); ++i) {
+        auto listSize = FixedListType::getNumValuesInList(&dataType);
+        children.reserve(listSize);
+        for (auto i = 0u; i < listSize; ++i) {
             children.push_back(std::make_unique<Value>(createDefaultValue(*childType)));
         }
         return Value(dataType, std::move(children));
@@ -206,12 +210,13 @@ Value::Value(uint8_t* val_) : isNull_{false} {
     val.pointer = val_;
 }
 
-Value::Value(LogicalType type, const std::string& val_) : isNull_{false} {
+Value::Value(const LogicalType& type, std::string val_) : isNull_{false} {
     dataType = type.copy();
-    strVal = val_;
+    strVal = std::move(val_);
 }
 
-Value::Value(LogicalType dataType_, std::vector<std::unique_ptr<Value>> children) : isNull_{false} {
+Value::Value(const LogicalType& dataType_, std::vector<std::unique_ptr<Value>> children)
+    : isNull_{false} {
     dataType = dataType_.copy();
     this->children = std::move(children);
     childrenSize = this->children.size();
@@ -444,7 +449,7 @@ Value::Value() : isNull_{true} {
     dataType = std::make_unique<LogicalType>(LogicalTypeID::ANY);
 }
 
-Value::Value(LogicalType dataType_) : isNull_{true} {
+Value::Value(const LogicalType& dataType_) : isNull_{true} {
     dataType = dataType_.copy();
 }
 

diff --git a/src/common/vector/value_vector.cpp b/src/common/vector/value_vector.cpp
@@ -17,7 +17,7 @@ ValueVector::ValueVector(LogicalType dataType, storage::MemoryManager* memoryMan
     auxiliaryBuffer = AuxiliaryBufferFactory::getAuxiliaryBuffer(this->dataType, memoryManager);
 }
 
-void ValueVector::setState(std::shared_ptr<DataChunkState> state_) {
+void ValueVector::setState(const std::shared_ptr<DataChunkState>& state_) {
     this->state = state_;
     if (dataType.getPhysicalType() == PhysicalTypeID::STRUCT) {
         auto childrenVectors = StructVector::getFieldVectors(this);

diff --git a/src/expression_evaluator/case_evaluator.cpp b/src/expression_evaluator/case_evaluator.cpp
@@ -68,6 +68,7 @@ bool CaseExpressionEvaluator::select(SelectionVector& selVector) {
 
 std::unique_ptr<ExpressionEvaluator> CaseExpressionEvaluator::clone() {
     std::vector<std::unique_ptr<CaseAlternativeEvaluator>> clonedAlternativeEvaluators;
+    clonedAlternativeEvaluators.reserve(alternativeEvaluators.size());
     for (auto& alternative : alternativeEvaluators) {
         clonedAlternativeEvaluators.push_back(alternative->clone());
     }

diff --git a/src/expression_evaluator/function_evaluator.cpp b/src/expression_evaluator/function_evaluator.cpp
@@ -55,6 +55,7 @@ bool FunctionExpressionEvaluator::select(SelectionVector& selVector) {
 
 std::unique_ptr<ExpressionEvaluator> FunctionExpressionEvaluator::clone() {
     std::vector<std::unique_ptr<ExpressionEvaluator>> clonedChildren;
+    clonedChildren.reserve(children.size());
     for (auto& child : children) {
         clonedChildren.push_back(child->clone());
     }