Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify csv and rdf reader config #2515

Merged
merged 1 commit into from
Nov 30, 2023
Merged

Unify csv and rdf reader config #2515

merged 1 commit into from
Nov 30, 2023

Conversation

andyfengHKU
Copy link
Contributor

  • refactor CsvReaderConfig & RdfReaderConfig inside ReaderConfig as ExtraReaderConfig.
  • using CSVOption instead of CSVReaderConfig during parsing.

@andyfengHKU andyfengHKU force-pushed the reader-config-refactor branch 3 times, most recently from c2acb9c to 8a40774 Compare November 30, 2023 06:14
Copy link

codecov bot commented Nov 30, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (ff5e450) 91.57% compared to head (0fe97a0) 91.57%.

Files Patch % Lines
src/function/cast_from_string_functions.cpp 98.03% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2515   +/-   ##
=======================================
  Coverage   91.57%   91.57%           
=======================================
  Files        1028     1029    +1     
  Lines       38036    38042    +6     
=======================================
+ Hits        34832    34838    +6     
  Misses       3204     3204           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andyfengHKU andyfengHKU merged commit 6560c39 into master Nov 30, 2023
14 checks passed
@andyfengHKU andyfengHKU deleted the reader-config-refactor branch November 30, 2023 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants