cmake: rewrite grammar generation #2540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The script to generate our grammar files is now written in CMake's scripting language, and as such is cross-platform. Additionally, the script is run as part of the build. We commit a copy of the Cypher.g4 file so that Java is not a build dependency of Kuzu: specifically, if the grammar has not changed, the generation command will do nothing. Additionally, a sanity check that the generated files are up to date has been added to CI.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2540 +/- ##
==========================================
+ Coverage 91.56% 92.86% +1.29%
==========================================
Files 1029 1025 -4
Lines 38059 38342 +283
==========================================
+ Hits 34849 35605 +756
+ Misses 3210 2737 -473 ☔ View full report in Codecov by Sentry. |
acquamarin
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The script to generate our grammar files is now written in CMake's scripting language, and as such is cross-platform. Additionally, the script is run as part of the build. We commit a copy of the Cypher.g4 file so that Java is not a build dependency of Kuzu: specifically, if the grammar has not changed, the generation command will do nothing.
Additionally, a sanity check that the generated files are up to date has been added to CI.