add support for exporting database to parquet files #2897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2897 +/- ##
==========================================
+ Coverage 93.45% 93.46% +0.01%
==========================================
Files 1104 1104
Lines 42468 42498 +30
==========================================
+ Hits 39687 39720 +33
+ Misses 2781 2778 -3 ☔ View full report in Codecov by Sentry. |
andyfengHKU
requested changes
Feb 16, 2024
src/include/parser/port_db.h
Outdated
|
|
||
| private: | ||
| parsing_option_t parsingOptions; | ||
| std::string filePath; | ||
| common::FileType fileType; |
There was a problem hiding this comment.
You can just keep a readerConfig in this class. If so let's rename it to BoundFileInfo
ray6080
changed the title
ray6080
changed the title
hououou
force-pushed
the
export_db_parquet
branch
from
9d57769
to
b1b6f99
Compare
andyfengHKU
approved these changes
Feb 17, 2024
slove comments fix
hououou
force-pushed
the
export_db_parquet
branch
from
8f9082b
to
cc95076
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.