Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created shell tests and fixed bugs #2940

Merged
merged 2 commits into from
Feb 26, 2024

Conversation

MSebanc
Copy link
Collaborator

@MSebanc MSebanc commented Feb 24, 2024

I have read and agree to the CLA of the Kuzu repository.

I have read and agree to the CLA of the Kuzu repository.
Copy link
Collaborator

@acquamarin acquamarin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Makefile Outdated Show resolved Hide resolved
tools/shell/linenoise.cpp Outdated Show resolved Hide resolved
tools/shell/test/conftest.py Outdated Show resolved Hide resolved
tools/shell/test/conftest.py Outdated Show resolved Hide resolved

KUZU_EXEC_PATH = os.path.join(KUZU_ROOT, 'build', 'release', 'tools', 'shell', 'kuzu_shell')

def _get_kuzu_version():
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we add a _ before the function name?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Python naming convention to mark a function as a private function

I have read and agree to the CLA of the Kuzu repository.
@MSebanc MSebanc merged commit d2cfc65 into kuzudb:master Feb 26, 2024
9 of 13 checks passed
@MSebanc MSebanc deleted the ShellTestingFramework branch February 26, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants