Support specifying max DB size in rust #2963
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2963 +/- ##
=======================================
Coverage 93.53% 93.53%
=======================================
Files 1122 1117 -5
Lines 42963 42925 -38
=======================================
- Hits 40184 40149 -35
+ Misses 2779 2776 -3 ☔ View full report in Codecov by Sentry. |
| @@ -46,6 +50,8 @@ impl Default for SystemConfig { | |||
| max_num_threads: 0, | |||
| enable_compression: true, | |||
| read_only: false, | |||
| // This is a little weird, but it's a temporary interface | |||
| max_db_size: u32::MAX as u64, | |||
There was a problem hiding this comment.
Why not initialize max_db_size in a similar way to buffer_pool_size?
There was a problem hiding this comment.
I was trying to match the default argument for the constructor, but it guess the rust API isn't using the C++ SystemConfig constructor anyway (it probably should, but I think it was written when the constructor was different).
-1u I guess is fine for the maxDBSize since it's not a power of two, but on the other hand, I think bufferPoolSize should default to zero instead since -1u is a valid value that just gets turned into auto-detection.
#2956 for the Rust API