Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix launch database using homedir #3108

Merged
merged 1 commit into from
Mar 22, 2024
Merged

Fix launch database using homedir #3108

merged 1 commit into from
Mar 22, 2024

Conversation

acquamarin
Copy link
Collaborator

closes #3104

src/main/database.cpp Show resolved Hide resolved
@acquamarin acquamarin force-pushed the home-dir-fix branch 4 times, most recently from 6bc9bd4 to 64a728e Compare March 22, 2024 19:33
Copy link

codecov bot commented Mar 22, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 91.87%. Comparing base (8f37501) to head (76695ce).
Report is 1 commits behind head on master.

Files Patch % Lines
src/common/file_system/file_system.cpp 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3108      +/-   ##
==========================================
- Coverage   91.89%   91.87%   -0.03%     
==========================================
  Files        1169     1169              
  Lines       43759    43746      -13     
==========================================
- Hits        40214    40192      -22     
- Misses       3545     3554       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@acquamarin acquamarin merged commit 167bb87 into master Mar 22, 2024
17 checks passed
@acquamarin acquamarin deleted the home-dir-fix branch March 22, 2024 21:00
ray6080 pushed a commit that referenced this pull request Mar 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Opening a database from the home directory causes a segmentation fault
2 participants