Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue-3129 #3131

Merged
merged 1 commit into from
Mar 24, 2024
Merged

Fix issue-3129 #3131

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/processor/operator/hash_join/join_hash_table.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,22 +245,22 @@
} break;
case PhysicalTypeID::INT8: {
func = hashEntry<int8_t>;
}
} break;

Check warning on line 248 in src/processor/operator/hash_join/join_hash_table.cpp

View check run for this annotation

Codecov / codecov/patch

src/processor/operator/hash_join/join_hash_table.cpp#L248 

Added line #L248 was not covered by tests
case PhysicalTypeID::UINT64: {
func = hashEntry<uint64_t>;
}
} break;

Check warning on line 251 in src/processor/operator/hash_join/join_hash_table.cpp

View check run for this annotation

Codecov / codecov/patch

src/processor/operator/hash_join/join_hash_table.cpp#L251 

Added line #L251 was not covered by tests
case PhysicalTypeID::UINT32: {
func = hashEntry<uint32_t>;
}
} break;

Check warning on line 254 in src/processor/operator/hash_join/join_hash_table.cpp

View check run for this annotation

Codecov / codecov/patch

src/processor/operator/hash_join/join_hash_table.cpp#L254 

Added line #L254 was not covered by tests
case PhysicalTypeID::UINT16: {
func = hashEntry<uint16_t>;
}
} break;

Check warning on line 257 in src/processor/operator/hash_join/join_hash_table.cpp

View check run for this annotation

Codecov / codecov/patch

src/processor/operator/hash_join/join_hash_table.cpp#L257 

Added line #L257 was not covered by tests
case PhysicalTypeID::UINT8: {
func = hashEntry<uint8_t>;
}
} break;

Check warning on line 260 in src/processor/operator/hash_join/join_hash_table.cpp

View check run for this annotation

Codecov / codecov/patch

src/processor/operator/hash_join/join_hash_table.cpp#L260 

Added line #L260 was not covered by tests
case PhysicalTypeID::INT128: {
func = hashEntry<int128_t>;
}
} break;
case PhysicalTypeID::DOUBLE: {
func = hashEntry<double>;
} break;
Expand Down
13 changes: 13 additions & 0 deletions test/test_files/issue/issue2.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,19 @@

--

-CASE 3129
-STATEMENT CREATE NODE TABLE V (id UUID, PRIMARY KEY(id));
---- ok
-STATEMENT CREATE REL TABLE E (FROM V TO V);
---- ok
-STATEMENT CREATE (v1:V {id: UUID('11111111-1111-1111-1111-111111111111')})-[:E]->(v2:V {id: UUID('22222222-2222-2222-2222-222222222222')});
---- ok
-STATEMENT MATCH (v:V {id: UUID('11111111-1111-1111-1111-111111111111')})
OPTIONAL MATCH (v)-[:E]->(v1:V)
RETURN v1.id
---- 1
22222222-2222-2222-2222-222222222222

-CASE 3055
-STATEMENT CREATE NODE TABLE test ( id STRING, prop1 STRING, prop2 INT64, prop3 STRING, prop4 STRING, PRIMARY KEY(id) )
---- ok
Expand Down
Loading