Fix #2888: error when commit/rollback on invalid transaction; fix error msg on nested transaction #3469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove incorrect rollback in execute interface; py lint; clean java test
benjaminwinger
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've got a bug introduced in #2953 when playing around the shell with transaction statements. Whenever there are errors thrown due to
COMMIT/ROLLBACK, the error message is hidden due to the shell incorrectly assumes thatCOMMIT/ROLLBACKare not valid cypher syntax. @MSebanc please see my TODO item inembedded_shell.cpp.