Add retry in templates to wait realtime notifications #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aschen
changed the title
scottinet
suggested changes
Nov 23, 2018
Snippets tests reports
|
Aschen
changed the title
scottinet
suggested changes
Nov 23, 2018
scottinet
suggested changes
Nov 23, 2018
| time.Sleep(4 * time.Second) | ||
| os.Exit(0) | ||
| }() | ||
|
|
||
| b := make([]byte, 4096) |
There was a problem hiding this comment.
You should make sure that the buffer has been completely emptied and printed before stopping the snippet: 4k may not be large enough
There was a problem hiding this comment.
I pick this value that should be enough because in the snippets we always print a string with a fixed length
alexandrebouthinon
approved these changes
Nov 26, 2018
alexandrebouthinon
force-pushed
the
fix-realtime-tests
branch
from
cb9253a
to
7cd127d
Compare
scottinet
approved these changes
Nov 27, 2018
benoitvidis
approved these changes
Nov 27, 2018
Aschen
commented
Nov 29, 2018
src/sdk-reference/js/6/realtime/subscribe/snippets/user-notifications.js
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add retry in templates to wait realtime notifications