Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cleanup] Fix mispelled words, wrong instructions in getting started ... #226

Merged
merged 2 commits into from
Feb 12, 2019

Conversation

alexandrebouthinon
Copy link
Member

@alexandrebouthinon alexandrebouthinon commented Feb 6, 2019

What does this PR do?

Thanks to @berthieresteban and @Yoann-Abbes, this PR fix and enhance our documentation:

  • Wrong request/response example in API document/replace route
  • Getting started C++:
    • Replace gcc by g++ and update compilation instructions following this.
    • Add LD_LIBRARY_PATH=${KUZZLE_SDK_PATH}/lib/ in execution instructions.
    • Fix copypasta error in realtime part.
  • Getting started Java:
    • Add warning for Java IDE users about getting started examples.
    • Fix dead link.
  • Fix dead link in js6 subscribe method

How should this be manually tested?

Netlify

@alexandrebouthinon alexandrebouthinon self-assigned this Feb 6, 2019
@kuzzle
Copy link
Contributor

kuzzle commented Feb 6, 2019

Snippets tests reports

SDK Version Tests overview
v6 ✔️
v5 ✔️
v1 ✔️
v1 ✔️
v1
v1 ✔️

@scottinet scottinet merged commit b0ae21f into master Feb 12, 2019
@scottinet scottinet deleted the polish branch February 12, 2019 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants