Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize directories and generate redirections #315

Merged
merged 12 commits into from
Jun 4, 2019
Merged

Conversation

Aschen
Copy link
Contributor

@Aschen Aschen commented May 31, 2019

What does this PR do?

Some structure changes:

  • api/api-reference/controller-xxx => api/controllers/xxx
  • guide/guides/xxx => guides/xxx
  • plugins/plugins/xxx => split entre plugins/guides/xxx et plugins/essentials
  • protocols/protocols/xxx => split entre protocols/api/xxx, protocols/essentials/xxx et protocols/native-protocols/xxx

JS 5, PHP 3 and Android 3 SDK are now on the same structures as the other SDK (core-classes, essentials)

The file redirections.yml contain all the redirection from the old v2 pages to new v3 pages.
Paths like api/1/controller-document are root path, redirection for files in subfolders has to be handled.

The script check_redirections.rb checks that every page from v2 has a redirection in v3.

I also replace every links after renaming/moving directories. (Maybe I miss some links but Vuepress have a dead link checker)

How to review it

Since a LOT of files have been moved, it's better to checkout the branch, run npm run dev and browse the documentation manually.

@Aschen Aschen self-assigned this May 31, 2019
@Aschen Aschen added the v3 label May 31, 2019
Copy link
Contributor

@scottinet scottinet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(there must be other non-converted URL to fix, but since you're now aware of the issue I'll let you handle it ;) )


## Overview

Metadata can be viewed in the document's `_meta` field and contains the following properties:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing since+deprecated property

something like that: <SinceBadge version="1.0.0" /> <DeprecatedBadge version="1.3.0" />

src/core/1/guides/essentials/installing-console/index.md Outdated Show resolved Hide resolved
src/core/1/guides/essentials/installing-console/index.md Outdated Show resolved Hide resolved
src/core/1/guides/essentials/installing-console/index.md Outdated Show resolved Hide resolved
src/core/1/guides/essentials/security/index.md Outdated Show resolved Hide resolved
src/core/1/guides/kuzzle-depth/authentication/index.md Outdated Show resolved Hide resolved
src/core/1/guides/kuzzle-depth/authentication/index.md Outdated Show resolved Hide resolved
src/core/1/guides/kuzzle-depth/authentication/index.md Outdated Show resolved Hide resolved
src/core/1/plugins/guides/controllers/index.md Outdated Show resolved Hide resolved
Copy link
Contributor

@benoitvidis benoitvidis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Guides entry link is broken in the main tabs menu.
In Tabs.vue => generateLink('core/1/guides')" (with an ending s)

Copy link
Contributor

@scottinet scottinet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one tiny issue left, otherwise this looks good to me

check_link.rb Outdated
require 'json'
require 'uri'
require 'typhoeus'
require 'optparse'

class LinkChecker
INTERNAL_LINK_REGEXP = /\(\{\{\s*site_base_path\s*\}\}([^)>]+)/
INTERNAL_LINK_REGEXP = /\[[\.\w\s\-]+\]\(([\w\/\-\#]*)\)/
# INTERNAL_LINK_REGEXP = /\(\{\{\s*site_base_path\s*\}\}([^)>]+)/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete this line, and all other commented out lines of this file.

@benoitvidis benoitvidis mentioned this pull request Jun 3, 2019
@Aschen Aschen merged commit 3acf4f2 into 3-dev Jun 4, 2019
@Aschen Aschen deleted the clean-directories branch June 4, 2019 08:17
@scottinet scottinet mentioned this pull request Jun 4, 2019
scottinet pushed a commit that referenced this pull request Jun 11, 2019
## What does this PR do?

Document kuzzleio/sdk-javascript#390

Based on #315

Original PR on v2: #297
This was referenced Jun 12, 2019
xbill82 added a commit that referenced this pull request Jun 13, 2019
# [3.0.0](https://github.com/kuzzleio/documentation/releases/tag/3.0.0) (2019-06-12)


#### Bug fixes

- [ [#298](#298) ] Fix bulk import return   ([Aschen](https://github.com/Aschen))
- [ [#325](#325) ] Adapt legacy redirection   ([Aschen](https://github.com/Aschen))
- [ [#322](#322) ] Fix remaining dead links and add check_link to CI   ([Aschen](https://github.com/Aschen))
- [ [#304](#304) ] Fix sdk js tests   ([benoitvidis](https://github.com/benoitvidis))

#### New features

- [ [#299](#299) ] Documentation for wildcard events   ([thomasarbona](https://github.com/thomasarbona))
- [ [#321](#321) ] Add guide about secrets management with the Vault   ([Aschen](https://github.com/Aschen))
- [ [#300](#300) ] Add page about bulk:write and bulk:mwrite   ([Aschen](https://github.com/Aschen))

#### Enhancements

- [ [#327](#327) ] SPA mode   ([xbill82](https://github.com/xbill82))
- [ [#324](#324) ] Update Redis version   ([Aschen](https://github.com/Aschen))
- [ [#316](#316) ] Sdks authenticated connected props   ([Aschen](https://github.com/Aschen))
- [ [#317](#317) ] Add new way for updateSpecifications & validateSpecifications   ([thomasarbona](https://github.com/thomasarbona))
- [ [#296](#296) ] Rewrite the Realtime guide   ([Aschen](https://github.com/Aschen))
- [ [#301](#301) ] Deprecate realtime join   ([Aschen](https://github.com/Aschen))
- [ [#291](#291) ] Getting started React + improve snippetManager   ([thomasarbona](https://github.com/thomasarbona))
- [ [#294](#294) ] Add s3 plugin   ([Aschen](https://github.com/Aschen))
- [ [#292](#292) ] Add since   ([Aschen](https://github.com/Aschen))
- [ [#276](#276) ] [KZL-907] Getting started dev plugin   ([Yoann-Abbes](https://github.com/Yoann-Abbes))
- [ [#284](#284) ] Extending the JS SDK with controllers   ([Aschen](https://github.com/Aschen))
- [ [#271](#271) ] Add documentation page about mappings   ([Aschen](https://github.com/Aschen))

#### Others

- [ [#314](#314) ] Add a clustering guide   ([scottinet](https://github.com/scottinet))
- [ [#319](#319) ] Getting-started-sdk-JS6-architecture   ([berthieresteban](https://github.com/berthieresteban))
- [ [#311](#311) ] Add PDF sending example for Request.setResult   ([Aschen](https://github.com/Aschen))
- [ [#315](#315) ] Normalize directories and generate redirections   ([Aschen](https://github.com/Aschen))
- [ [#309](#309) ] Port #284 to 3-dev   ([berthieresteban](https://github.com/berthieresteban))
- [ [#308](#308) ] Port #283 to 3-dev   ([berthieresteban](https://github.com/berthieresteban))
- [ [#307](#307) ] Port #282 to 3-dev   ([berthieresteban](https://github.com/berthieresteban))
- [ [#306](#306) ] Port #280 to 3-dev   ([berthieresteban](https://github.com/berthieresteban))
- [ [#312](#312) ] Port 278 to 3-dev   ([Aschen](https://github.com/Aschen))
- [ [#310](#310) ] Port #277 to 3-dev   ([Aschen](https://github.com/Aschen))
- [ [#305](#305) ] Port #275 to 3-dev   ([Aschen](https://github.com/Aschen))
- [ [#303](#303) ] Port #274 to 3-dev   ([Aschen](https://github.com/Aschen))
- [ [#302](#302) ] Port #271 to 3-dev   ([Aschen](https://github.com/Aschen))
- [ [#313](#313) ] Port #266 to 3-dev   ([Yoann-Abbes](https://github.com/Yoann-Abbes))
- [ [#290](#290) ] [KZL-1050] Role template example in the documentation   ([Yoann-Abbes](https://github.com/Yoann-Abbes))
- [ [#293](#293) ] [KZL-1036] Add available plugins   ([Yoann-Abbes](https://github.com/Yoann-Abbes))
- [ [#286](#286) ] Embedded protocols   ([benoitvidis](https://github.com/benoitvidis))
---
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants