Prettify metadata when fetching assets and devices from API #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aschen
suggested changes
Oct 11, 2022
Comment on lines
+209
to
+239
| (request.input.args.collection === "assets" || | ||
| request.input.args.collection === "devices") && | ||
| request.input.args.options?.prettify | ||
| ) { | ||
| for (const document of documents) { | ||
| if (document._source?.metadata) { | ||
| document._source.metadata = | ||
| this.assetCategoryService.formatMetadataForGet( | ||
| document._source.metadata | ||
| ); | ||
| } | ||
| } | ||
| } | ||
| return documents; | ||
| }, | ||
| "generic:document:beforeUpdate": async (documents, request: Request) => { | ||
| if ( | ||
| (request.input.args.collection === "assets" || | ||
| request.input.args.collection === "devices") && | ||
| request.input.args.options?.prettify | ||
| ) { | ||
| for (const document of documents) { | ||
| if (document._source?.metadata) { | ||
| document._source.metadata = | ||
| this.assetCategoryService.formatMetadataForES( | ||
| document._source.metadata | ||
| ); | ||
| } | ||
| } | ||
| } | ||
| return documents; |
There was a problem hiding this comment.
I can do something like
pipeFunction(myFunction)
if (
(request.input.args.collection === "assets" ||
request.input.args.collection === "devices") &&
request.input.args.options?.prettify
) {
for (const document of documents) {
if (document._source?.metadata) {
document._source.metadata =
myFunction(
document._source.metadata
);
}
}
}
...
this.pipes = {
....
"generic:document:afterGet": async (documents, request: Request) => {
return pipeFunction( this.assetCategoryService.formatMetadataForGet);}
"generic:document:beforeUpdate": async (documents, request: Request) => {
return pipeFunction(this.assetCategoryService.formatMetadataForES);}
};
It's more concise, but, in my opinion, (even with better naming) less readable.
sebtiz13
reviewed
Oct 11, 2022
Yes, but when I start to work, the new architecture was not merged :-( |
Aschen
changed the title
I checked and it was not that hard, I did it ;-) |
added 3 commits
October 17, 2022 18:30
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.