refactor: add BaseService #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebtiz13
force-pushed
the
refactor/services
branch
from
3e4f44b
to
3dd7dca
Compare
sebtiz13
force-pushed
the
refactor/services
branch
from
3dd7dca
to
96aa300
Compare
tdislay
approved these changes
Oct 25, 2023
fmauNeko
approved these changes
Oct 25, 2023
|
🎉 This PR is included in version 2.4.0-beta.7 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 2.4.0-temp-ci-debug.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 2.4.0-temp-ci-debug.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Refactor services to use the abstract shared class
BaseService.This abstract class provide some useful getters like
sdk,impersonatedSdk,config.Also to future, this allows to provide easily other getters or methods shared between services.