Improve distribution of this package #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Github Package Registry is fine 👍 |
Aschen
approved these changes
Apr 20, 2023
OlivierCavadenti
approved these changes
Apr 20, 2023
I think I'll push to NPM directly instead, it'll make life easier when migrating (not having to put the package in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
This PR removes the transpiled filed from versioning and sets up TypeScript/NPM so that they can be cleanly published to the public registry. Linting rules were also added.
CI jobs were configured to run the linter on PRs, and run the linter and publish the package when pushing on master. They are not guaranteed to work on this attempt tho' :-)
The CI is currently set up to publish the package to GitHub's package registry. Do we keep that or do we publish to the NPM registry directly?