Merge pull request #2531 from kuzzleio/fix/hset-and-hmset-0-value

fix: hmset, mset should accept value = 0
kuzzleio · May 22, 2024 · 8099cc2 · 8099cc2
2 parents 6e3dda6 + cb685f9
commit 8099cc2
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 3 deletions.
diff --git a/lib/api/controllers/memoryStorageController.js b/lib/api/controllers/memoryStorageController.js
@@ -267,11 +267,15 @@ function initMapping() {
           kassert.assertBodyAttributeType(request, "entries", "array");
 
           val.forEach((v) => {
-            if (typeof v !== "object" || !v.field || !v.value) {
+            if (
+              typeof v !== "object" ||
+              !v.field ||
+              (!v.value && v.value !== 0)
+            ) {
               throw kerror.get(
                 "invalid_argument",
                 "entries",
-                "<array of object>",
+                "<array of objects>",
               );
             }
 
@@ -348,7 +352,11 @@ function initMapping() {
           kassert.assertBodyHasAttribute(request, "entries");
           kassert.assertBodyAttributeType(request, "entries", "array");
           val.forEach((entry) => {
-            if (typeof entry !== "object" || !entry.key || !entry.value) {
+            if (
+              typeof entry !== "object" ||
+              !entry.key ||
+              (!entry.value && entry.value !== 0)
+            ) {
               throw kerror.get(
                 "invalid_argument",
                 "entries",

diff --git a/test/api/controllers/memoryStorageController.test.js b/test/api/controllers/memoryStorageController.test.js
@@ -1022,6 +1022,7 @@ describe("MemoryStorageController", () => {
           entries: [
             { field: "foo", value: "bar" },
             { field: "baz", value: "qux" },
+            { field: "bar", value: 0 },
           ],
         },
       });
@@ -1096,6 +1097,7 @@ describe("MemoryStorageController", () => {
             { key: "key1", value: "value1" },
             { key: "key2", value: "value2" },
             { key: "key3", value: "value3" },
+            { key: "key4", value: 0 },
           ],
         },
       });
@@ -1109,6 +1111,8 @@ describe("MemoryStorageController", () => {
         "value2",
         "key3",
         "value3",
+        "key4",
+        0,
       ]);
     });