Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix URL parsing w/ trailing slash & querystring #1538

wants to merge 2 commits into
base: 1-dev


Copy link

scottinet commented Dec 2, 2019


Fix a bug where an URL containing both a trailing slash and a querystring would be incorrectly parsed.

How to reproduce

The following HTTP GET request works fine:


But not this one without this PR:


Both requests are equivalent and should be regarded as identical.


This comment has been minimized.

Copy link

codecov bot commented Dec 2, 2019

Codecov Report

Merging #1538 into 1-dev will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##            1-dev    #1538   +/-   ##
  Coverage   94.37%   94.37%           
  Files         106      106           
  Lines        7378     7378           
  Hits         6963     6963           
  Misses        415      415
Impacted Files Coverage Δ
lib/api/core/httpRouter/routePart.js 100% <100%> (ø) ⬆️
lib/api/core/httpRouter/index.js 98.71% <100%> (-0.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ceb67f...3472275. Read the comment docs.

Aschen approved these changes Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
2 participants
You can’t perform that action at this time.