Fix URL parsing w/ trailing slash & querystring #1538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 1-dev #1538 +/- ##
=======================================
Coverage 94.37% 94.37%
=======================================
Files 106 106
Lines 7378 7378
=======================================
Hits 6963 6963
Misses 415 415
Continue to review full report at Codecov.
|
Aschen
approved these changes
Dec 4, 2019
Yoann-Abbes
approved these changes
Dec 6, 2019
Merged
Aschen
added a commit
that referenced
this pull request
Jun 8, 2020
# [1.11.1](https://github.com/kuzzleio/kuzzle/releases/tag/1.11.1) (2020-06-05) #### Bug fixes - [ [#1638](#1638) ] Allows external user sdk impersonation ([Aschen](https://github.com/Aschen)) - [ [#1538](#1538) ] Fix URL parsing w/ trailing slash & querystring ([scottinet](https://github.com/scottinet)) - [ [#1529](#1529) ] Fix shutdown process ([scottinet](https://github.com/scottinet)) ---
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix a bug where an URL containing both a trailing slash and a querystring would be incorrectly parsed.
How to reproduce
The following HTTP GET request works fine:
http://localhost:7512/_now?prettyBut not this one without this PR:
http://localhost:7512/_now/?prettyBoth requests are equivalent and should be regarded as identical.