Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure the ID Card Renewer is killed when the main process exit or is killed with a signal #2443

Merged
merged 3 commits into from
Apr 3, 2023

Conversation

Shiranuit
Copy link
Contributor

What does this PR do ?

Ensure the ID Card Renewer is killed when the main process exit or is killed with a signal.

Especially when using the Ergol to hot restart Kuzzle when developing.

@kuzzle
Copy link
Contributor

kuzzle commented Mar 30, 2023

Executed Checks

✔️ Branch Merge Check

✔️ Changelog Tag Check

✔️ PR Body Check

Generated by 🚫 dangerJS against 86a3b2e

@sonarcloud
Copy link

sonarcloud bot commented Mar 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Shiranuit Shiranuit merged commit 421d44d into 2-dev Apr 3, 2023
@Aschen Aschen deleted the hotrestart-subprocess branch April 3, 2023 15:37
@Shiranuit Shiranuit mentioned this pull request Apr 19, 2023
Shiranuit added a commit that referenced this pull request Apr 19, 2023
* Ensure the ID Card Renewer is killed when the main process exit or is killed with a signal (#2443)

* ensure the subprocess is killed when the main process exit or is killed

* ensure the process is killed when receiving a sigkill / sigterm

* lint

* Bump koncorde to 4.1.0 (#2445)

* Bump koncorde to 4.1.0

* add koncordedoc

* add version badge

* Release 2.22.0
@Shiranuit Shiranuit mentioned this pull request Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants