Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update node version to <= 16 instead of >= 12 #2448

Merged
merged 1 commit into from
Apr 20, 2023
Merged

Conversation

thomas-mauran
Copy link
Contributor

Just update the node version to avoid any mistakes for new users

By doing this we can reduce frustration for new users who try to run kuzzle for the first time and deal with an error.

@thomas-mauran thomas-mauran self-assigned this Apr 20, 2023
@sonarcloud
Copy link

sonarcloud bot commented Apr 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@kuzzle
Copy link
Contributor

kuzzle commented Apr 20, 2023

Fails
🚫 Found some issues !

Executed Checks

❌ Branch Merge Check

Merging "fix/nodeVersion" into "master" is not allowed.
If you want to allow this PR to be merged into "master", add the following line to your PR body:

ci-allow-merge-into: master

❌ Changelog Tag Check

Pull Requests must have a changelog:XXX label.
If you want to allow this PR to not have a changelog tag, add the following line to the PR body:

ci-no-changelog-tag

✔️ PR Body Check

Generated by 🚫 dangerJS against 214f9d1

@Aschen Aschen merged commit 34c75be into master Apr 20, 2023
@Aschen Aschen deleted the fix/nodeVersion branch April 20, 2023 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants