-
Notifications
You must be signed in to change notification settings - Fork 2
Conversation
Codecov Report
@@ Coverage Diff @@
## 3.x #134 +/- ##
==========================================
+ Coverage 91.34% 91.38% +0.04%
==========================================
Files 33 33
Lines 4148 4320 +172
Branches 397 419 +22
==========================================
+ Hits 3789 3948 +159
- Misses 255 264 +9
- Partials 104 108 +4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You only removed a fetchAllDocuments
overload, the main implementation is still there.
0555139
to
0cf82b2
Compare
oops.. -_-;... fixed |
this.fetchAllDocuments(new Options(), listener); | ||
} | ||
|
||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You only removed a signature of fetchAlldocuments
, the actual method doing the job is still just below :)
This PR removes the
fetchAllDocuments
method from the SDK, which can be better replaced by asearch
+fetchNext
call (documentation to come).