Add specification CRUDL routes #135
Conversation
Codecov Report
@@ Coverage Diff @@
## 3.x #135 +/- ##
==========================================
+ Coverage 91.13% 91.81% +0.67%
==========================================
Files 33 33
Lines 4571 5558 +987
Branches 427 578 +151
==========================================
+ Hits 4166 5103 +937
- Misses 286 322 +36
- Partials 119 133 +14
Continue to review full report at Codecov.
|
| * @param options Options Optional parameters | ||
| * @param listener Response callback | ||
| */ | ||
| public void scrollSpecifications(@NonNull final String scrollId, final Options options, @NonNull final ResponseListener<JSONObject> listener) { |
There was a problem hiding this comment.
For the sake of consistency, shouldn't this method resolve to a SearchResults object instead of a raw JSONObject?
If so, then the corresponding documentation should be updated accordingly.
| * @param options Options Optional parameters | ||
| * @param listener Response callback | ||
| */ | ||
| public void searchSpecifications(final JSONObject filters, final Options options, @NonNull final ResponseListener<JSONObject> listener) { |
There was a problem hiding this comment.
Same here: other search methods resolve to a SearchObject object, maybe this one should too?
|
@scottinet Just updated this PR according to your comments |
samniisan
force-pushed
the
3-data-validation
branch
from
2bc2d5e
to
e3d2a8d
Compare
| * @param options Options Optional parameters | ||
| * @param listener Response callback | ||
| */ | ||
| public void validateSpecifications(@NonNull JSONObject specifications, Options options, @NonNull final ResponseListener<Boolean> listener) throws JSONException { |
There was a problem hiding this comment.
You should check if listener is null and throw an IllegalArgumentException if so
fix kuzzleio/kuzzle-sdk#3
Introduces