Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kuzzle v2 compatibility #43

Merged
merged 11 commits into from
Nov 27, 2019
Merged

Kuzzle v2 compatibility #43

merged 11 commits into from
Nov 27, 2019

Conversation

Aschen
Copy link
Contributor

@Aschen Aschen commented Nov 22, 2019

What does this PR do ?

Ensure SDK compatibility with Kuzzle v2:

  • Use Kuzzle v2 images in Docker Compose
  • Update the NuGet version
  • Update API methods (See full list of breaking changes in Kuzzle 2.0.0 )

@codecov
Copy link

codecov bot commented Nov 25, 2019

Codecov Report

Merging #43 into 2-dev will increase coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##            2-dev      #43      +/-   ##
==========================================
+ Coverage   83.24%   83.31%   +0.06%     
==========================================
  Files          34       34              
  Lines        1665     1636      -29     
  Branches      200      195       -5     
==========================================
- Hits         1386     1363      -23     
+ Misses        257      251       -6     
  Partials       22       22
Impacted Files Coverage Δ
Kuzzle/API/Controllers/IndexController.cs 100% <ø> (ø) ⬆️
Kuzzle/API/Controllers/DocumentController.cs 100% <100%> (ø) ⬆️
Kuzzle/Kuzzle.cs 82.5% <100%> (+0.22%) ⬆️
Kuzzle/API/Controllers/CollectionController.cs 100% <100%> (+4.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 875ed36...cc3c93b. Read the comment docs.

@Aschen Aschen removed the wip label Nov 26, 2019
Copy link
Contributor

@scottinet scottinet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation wording

doc/2/controllers/bulk/import-async/index.md Outdated Show resolved Hide resolved
doc/2/controllers/bulk/import-async/index.md Outdated Show resolved Hide resolved
doc/2/controllers/bulk/import-async/index.md Outdated Show resolved Hide resolved
doc/2/controllers/bulk/import-async/index.md Outdated Show resolved Hide resolved
doc/2/controllers/bulk/mwrite-async/index.md Outdated Show resolved Hide resolved
doc/2/controllers/document/m-replace/index.md Outdated Show resolved Hide resolved
doc/2/controllers/document/m-replace/index.md Outdated Show resolved Hide resolved
doc/2/controllers/document/m-update/index.md Outdated Show resolved Hide resolved
doc/2/controllers/document/m-update/index.md Outdated Show resolved Hide resolved
doc/2/controllers/document/m-update/index.md Outdated Show resolved Hide resolved
Co-Authored-By: Sébastien Cottinet <scottinet@protonmail.com>
@scottinet scottinet merged commit ddfb4d1 into 2-dev Nov 27, 2019
@scottinet scottinet mentioned this pull request Nov 27, 2019
scottinet added a commit that referenced this pull request Nov 27, 2019
# [2.0.0](https://github.com/kuzzleio/sdk-csharp/releases/tag/2.0.0) (2019-11-27)


#### Breaking changes

- [ [#43](#43) ] Kuzzle v2 compatibility   ([Aschen](https://github.com/Aschen))
---
@scottinet scottinet mentioned this pull request Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants