Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java build #147

Merged
merged 41 commits into from
Apr 26, 2018
Merged

Java build #147

merged 41 commits into from
Apr 26, 2018

Conversation

jenow
Copy link
Contributor

@jenow jenow commented Apr 24, 2018

What does this PR do ?

Builds a JAR file for the Java SDK using gradle

How should this be manually tested?

run make java in internal/wrappers/build/java and see if kuzzlesdk-1.0.0-sources.jar and kuzzlesdk-1.0.0-javadoc.jar are present in internal/wrappers/build/java/build/libs

Note

This does not build multi architecture JAR file. This will be done in another PR which will deploy the JAR's files on maven

@jenow jenow added the blocked label Apr 24, 2018
@codecov-io
Copy link

codecov-io commented Apr 24, 2018

Codecov Report

Merging #147 into 1.x will decrease coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##            1.x    #147     +/-   ##
======================================
- Coverage    89%   88.9%   -0.1%     
======================================
  Files       244     244             
  Lines      4382    4382             
======================================
- Hits       3900    3896      -4     
- Misses      451     455      +4     
  Partials     31      31
Impacted Files Coverage Δ
realtime/subscribe.go 71.42% <0%> (-5.72%) ⬇️
realtime/join.go 72.97% <0%> (-5.41%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cffa4f6...54443ef. Read the comment docs.

@jenow jenow added the wip label Apr 25, 2018
@jenow
Copy link
Contributor Author

jenow commented Apr 25, 2018

I put this PR in wip because I need to organise the generated java source files as a real java project otherwise we can't publish it on maven as by default the publisher is looking for a src/java/main project

@jenow jenow changed the base branch from 1.x to master April 25, 2018 13:53
@jenow jenow changed the base branch from master to 1.x April 25, 2018 13:53
@Aschen
Copy link
Contributor

Aschen commented Apr 26, 2018

I had some trouble to manually test this PR and build the java SDK.

  • Install swig
  • Install JDK8 (not compatible with JDK9)
  • Set JAVA_HOME

Maybe it can be useful to document the dependencies (or step) to achieve a java sdk build ?

Otherwise, the build is here internal/wrappers/build/java/build/libs/ and not here internal/wrappers/build/java/libs/

@jenow jenow merged commit c5e60bc into 1.x Apr 26, 2018
@jenow jenow deleted the java-build branch April 26, 2018 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants