Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a mapping argument to existing collection.create methods #183

Merged
merged 4 commits into from
Aug 1, 2018

Conversation

scottinet
Copy link
Contributor

@scottinet scottinet commented Jul 25, 2018

What does this PR do ?

Allow Collection.create in Go, C++ and Java to handle a mapping argument, allowing to create new collections directly with a user-mapping specified.

Unit & functional tests have been added.

Other changes

  • Add a SWIG template for Java to make it handle pointers to std::string (@jenow)

Boyscout

  • Fix outdated test script name in the README file
  • Fix a typo in functional test scenarios
  • Add a ulimit configuration to elasticsearch's docker-compose, to allow it to run on computers with a number of opened files set with a low value

@scottinet scottinet removed the wip label Jul 26, 2018
@codecov-io
Copy link

codecov-io commented Jul 26, 2018

Codecov Report

Merging #183 into 1.x will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              1.x     #183      +/-   ##
==========================================
+ Coverage   88.88%   88.92%   +0.03%     
==========================================
  Files         244      244              
  Lines        4410     4416       +6     
==========================================
+ Hits         3920     3927       +7     
+ Misses        458      457       -1     
  Partials       32       32
Impacted Files Coverage Δ
collection/create.go 100% <100%> (ø) ⬆️
kuzzle/queue.go 18.18% <0%> (-6.82%) ⬇️
realtime/join.go 78.37% <0%> (+5.4%) ⬆️
realtime/subscribe.go 77.14% <0%> (+5.71%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5bcb3fc...95341b9. Read the comment docs.

@jenow jenow merged commit 351e679 into 1.x Aug 1, 2018
@jenow jenow deleted the collection-create-accept-mappings branch August 1, 2018 09:36
@jenow jenow mentioned this pull request Sep 10, 2018
@jenow jenow mentioned this pull request Jun 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants