Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap Auth controller for Android SDK #185

Merged
merged 1 commit into from
Aug 2, 2018
Merged

Conversation

jenow
Copy link
Contributor

@jenow jenow commented Aug 1, 2018

What does this PR do ?

Wrap Auth controller method for Android SDK in order to take and return JSONObject type when needed

How should this be manually tested?

run docker run --rm -it -v "$(pwd)":/go/src/github.com/kuzzleio/sdk-go android-x86 /build.sh
Use internal/wrappers/build/android/app/build/outputs/aar/app-release.aar in an android project and see if you have JSONObject type on the Auth controller's methods

@jenow jenow self-assigned this Aug 1, 2018
@codecov-io
Copy link

codecov-io commented Aug 1, 2018

Codecov Report

Merging #185 into 1.x will increase coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              1.x     #185      +/-   ##
==========================================
+ Coverage   88.89%   88.98%   +0.09%     
==========================================
  Files         244      244              
  Lines        4413     4413              
==========================================
+ Hits         3923     3927       +4     
+ Misses        458      454       -4     
  Partials       32       32
Impacted Files Coverage Δ
realtime/join.go 78.37% <0%> (+5.4%) ⬆️
realtime/subscribe.go 77.14% <0%> (+5.71%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0ff871...c760dc5. Read the comment docs.

@Aschen
Copy link
Contributor

Aschen commented Aug 2, 2018

Do we have to do this for every controllers ?

@jenow
Copy link
Contributor Author

jenow commented Aug 2, 2018

@Aschen Every controller which contains methods with String which represents a JSON

@jenow jenow merged commit 88ef8d9 into 1.x Aug 2, 2018
@jenow jenow deleted the KZL-227-android-wrap-auth branch August 2, 2018 16:08
@jenow jenow mentioned this pull request Sep 10, 2018
@jenow jenow mentioned this pull request Jun 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants