Adapt the SDK to the controller refactor #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[MASTER] Hotfix IE 11
Conflicts: README.md package.json
xbill82
approved these changes
Dec 12, 2016
benoitvidis
approved these changes
Dec 12, 2016
Current coverage is 99.93% (diff: 100%)@@ develop #152 diff @@
==========================================
Files 15 15
Lines 1535 1536 +1
Methods 251 251
Messages 0 0
Branches 403 403
==========================================
+ Hits 1534 1535 +1
Misses 1 1
Partials 0 0
|
This was referenced Dec 13, 2016
scottinet
suggested changes
Dec 13, 2016
| @@ -4,7 +4,7 @@ | |||
| Official Kuzzle Javascript SDK | |||
| ====== | |||
|
|
|||
| This SDK version is compatible with Kuzzle 1.0.0-RC6 and higher | |||
| This SDK version is compatible with Kuzzle 1.0.0-RC8 and higher | |||
There was a problem hiding this comment.
As @benoitvidis said to me (and I agree): is this really necessary?
Since we won't have any real users until v1 is out, shouldn't we remove this sentence altogether?
| @@ -140,6 +140,10 @@ kuzzle | |||
| }); | |||
| ``` | |||
|
|
|||
| ## Building manually | |||
|
|
|||
| Clone this github repository and run ``npm run build``. A ``dist`` directory will be created, containing a plain browserified version of this SDK, and a minified version. | |||
There was a problem hiding this comment.
I removed this section because I've rewritten the README. There is no "browserified" version anymore, and since this step is required to use the SDK in a browser, I've already detailed the procedure in the "Installation/Javascript" section.
I think this section should go.
|
@scottinet Done |
scottinet
approved these changes
Dec 13, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
linked to kuzzleio/kuzzle#567