Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure User to be able to store both content and credentials #215

Merged
merged 9 commits into from
May 12, 2017

Conversation

dbengsch
Copy link
Contributor

@dbengsch dbengsch commented May 11, 2017

  • Restructure User to be able to store both content and credentials;
  • Split User.save method into User.create and User.replace methods

fixes kuzzleio/kuzzle-sdk#21

Conflicts:
	src/Kuzzle.js
	test/security/kuzzleSecurity/userMethods.test.js
	test/security/kuzzleUser/methods.test.js
@codecov-io
Copy link

codecov-io commented May 11, 2017

Codecov Report

Merging #215 into 5.x will increase coverage by 0.29%.
The diff coverage is 97.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##              5.x     #215      +/-   ##
==========================================
+ Coverage   98.47%   98.76%   +0.29%     
==========================================
  Files          17       17              
  Lines        1768     2031     +263     
  Branches      475      584     +109     
==========================================
+ Hits         1741     2006     +265     
+ Misses         27       25       -2
Impacted Files Coverage Δ
src/security/Security.js 100% <100%> (+0.4%) ⬆️
src/security/User.js 99.01% <96.96%> (-0.99%) ⬇️
src/Kuzzle.js 99.31% <0%> (+0.67%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a3fee1...f19f5dc. Read the comment docs.

@scottinet scottinet merged commit 44845db into 5.x May 12, 2017
@scottinet scottinet deleted the 21-adapt-replace branch May 12, 2017 07:44
This was referenced May 24, 2017
@scottinet scottinet mentioned this pull request Jun 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants