-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructure User to be able to store both content and credentials #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…place createOrReplace in save method
Conflicts: src/Kuzzle.js test/security/kuzzleSecurity/userMethods.test.js test/security/kuzzleUser/methods.test.js
Codecov Report
@@ Coverage Diff @@
## 5.x #215 +/- ##
==========================================
+ Coverage 98.47% 98.76% +0.29%
==========================================
Files 17 17
Lines 1768 2031 +263
Branches 475 584 +109
==========================================
+ Hits 1741 2006 +265
+ Misses 27 25 -2
Continue to review full report at Codecov.
|
xbill82
approved these changes
May 11, 2017
scottinet
approved these changes
May 12, 2017
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes kuzzleio/kuzzle-sdk#21