Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename getProfiles to getProfileIds and add a proper getProfiles method #225

Merged
merged 4 commits into from
Jun 1, 2017

Conversation

scottinet
Copy link
Contributor

Description

  • User.getProfiles is renamed to User.getProfileIds
  • User.getProfileIds now returns an empty array instead of undefined if no profile is attached to the user object
  • add a new User.getProfiles method fetching profiles from Kuzzle API and returning an array of Profile objects

Boyscout

Update README file

Related issue

https://github.com/kuzzleio/kuzzle-sdk/issues/33

@codecov-io
Copy link

codecov-io commented Jun 1, 2017

Codecov Report

Merging #225 into 5.x will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              5.x     #225      +/-   ##
==========================================
+ Coverage   98.15%   98.17%   +0.01%     
==========================================
  Files          17       17              
  Lines        1953     1971      +18     
  Branches      556      562       +6     
==========================================
+ Hits         1917     1935      +18     
  Misses         36       36
Impacted Files Coverage Δ
src/security/User.js 98.76% <100%> (+0.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aea8fa5...303954f. Read the comment docs.

@ballinette ballinette merged commit 9066a3b into 5.x Jun 1, 2017
@ballinette ballinette deleted the fix-33 branch June 1, 2017 15:02
@scottinet scottinet mentioned this pull request Jun 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants