Add specification CRUDL routes #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 5.x #231 +/- ##
==========================================
+ Coverage 98.56% 98.72% +0.16%
==========================================
Files 17 17
Lines 2085 2512 +427
Branches 595 762 +167
==========================================
+ Hits 2055 2480 +425
- Misses 30 32 +2
Continue to review full report at Codecov.
|
scottinet
reviewed
Jun 12, 2017
| * @param {object} [options] - Optional parameters | ||
| * @param {responseCallback} cb - Handles the query response | ||
| */ | ||
| Collection.prototype.scrollSpecifications = function (scrollId, options, cb) { |
There was a problem hiding this comment.
Other scroll methods return a KuzzleSearchResult object, shouldn't this one do the same?
| * @param {object} [options] - Optional parameters | ||
| * @param {responseCallback} cb - Handles the query response | ||
| */ | ||
| Collection.prototype.searchSpecifications = function (filters, options, cb) { |
There was a problem hiding this comment.
Other search methods return a KuzzleSearchResult object, shouldn't this one do the same?
|
@scottinet Just updated this PR according to your comments |
scottinet
approved these changes
Jun 13, 2017
stafyniaksacha
approved these changes
Jun 13, 2017
samniisan
force-pushed
the
3-data-validation
branch
from
6410513
to
2d099f1
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix kuzzleio/kuzzle-sdk#3
Introduces