Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.x] collection.create can be used with a mapping #300

Merged
merged 5 commits into from Jul 26, 2018

Conversation

scottinet
Copy link
Contributor

@scottinet scottinet commented Jul 24, 2018

What does this PR do?

The API route collection:create can be used with a mapping since Kuzzle 1.3.0, allowing the creation of a collection directly with a mapping specified: https://docs.kuzzle.io/api-documentation/controller-collection/create

This feature is missing from SDKs, and this PR fixes that for the version 5 of this SDK

Other changes

  • Dependencies update (including webpack 1 => 4)
  • Fix: mocha now blocks unit tests until the event loop is empty. Some of our unit tests left networking related tasks in the event loop, preventing unit tests to ever finish.
  • Update to Sinon 6 and update obsolete usages of that module
  • Replace istanbul (obsolete) with nyc

@scottinet scottinet changed the title collection.create can be used with a mapping [5.x] collection.create can be used with a mapping Jul 24, 2018
@codecov-io
Copy link

codecov-io commented Jul 24, 2018

Codecov Report

Merging #300 into 5.x will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              5.x     #300      +/-   ##
==========================================
+ Coverage   98.31%   98.34%   +0.03%     
==========================================
  Files          17       17              
  Lines        2138     2118      -20     
  Branches      609        0     -609     
==========================================
- Hits         2102     2083      -19     
+ Misses         36       35       -1
Impacted Files Coverage Δ
src/Collection.js 98.18% <100%> (+0.14%) ⬆️
src/SearchResult.js 94.54% <0%> (-0.46%) ⬇️
src/eventEmitter/index.js 92.13% <0%> (-0.34%) ⬇️
src/networkWrapper/wrappers/websocket.js 98.61% <0%> (-0.1%) ⬇️
src/CollectionMapping.js 97.67% <0%> (-0.06%) ⬇️
src/Document.js 98.97% <0%> (-0.05%) ⬇️
src/SubscribeResult.js 100% <0%> (ø) ⬆️
src/security/SecurityDocument.js 100% <0%> (ø) ⬆️
src/Room.js 100% <0%> (ø) ⬆️
src/security/Role.js 100% <0%> (ø) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6237dd8...c9b2a71. Read the comment docs.

@jenow jenow merged commit 27e9b16 into 5.x Jul 26, 2018
@jenow jenow deleted the collection-create-accept-mappings branch July 26, 2018 10:57
@scottinet scottinet mentioned this pull request Jul 27, 2018
This was referenced Sep 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants