realtime: fix bug #332
Merged
realtime: fix bug #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-fixed bug where subscribe would return a Room instead of just the roomId
-fixed test accordingly
Codecov Report
@@ Coverage Diff @@
## 6-dev #332 +/- ##
=======================================
Coverage 97.49% 97.49%
=======================================
Files 28 28
Lines 1395 1395
=======================================
Hits 1360 1360
Misses 35 35
Continue to review full report at Codecov.
|
Aschen
approved these changes
Oct 31, 2018
alexandrebouthinon
approved these changes
Oct 31, 2018
alexandrebouthinon
deleted the
KZL-788-subscribe-shall-return-the-roomId
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR makes
realtime::subscribejavascript API consistent with other langages.Instead of resolving to the object
{ channel: 'foo', roomId: 'bar' }, it resolves to 'bar'How should this be manually tested?
You can now unsubscribe directly with the result of subscribe