Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the MappingsProperties type #705

Merged
merged 4 commits into from
Aug 31, 2022
Merged

Fix the MappingsProperties type #705

merged 4 commits into from
Aug 31, 2022

Conversation

Aschen
Copy link
Contributor

@Aschen Aschen commented Aug 8, 2022

What does this PR do ?

Fix the MappingsProperties type to reflect the real mappings object structure

@Aschen Aschen self-assigned this Aug 8, 2022
@Aschen Aschen changed the base branch from master to 7-dev August 8, 2022 10:21
@codecov
Copy link

codecov bot commented Aug 8, 2022

Codecov Report

Merging #705 (354f15a) into 7-dev (a8e94a1) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##            7-dev     #705      +/-   ##
==========================================
- Coverage   83.48%   83.47%   -0.01%     
==========================================
  Files          45       45              
  Lines        2095     2100       +5     
  Branches      370      370              
==========================================
+ Hits         1749     1753       +4     
- Misses        268      269       +1     
  Partials       78       78              
Impacted Files Coverage Δ
src/core/Room.js 96.77% <0.00%> (-3.23%) ⬇️
src/Kuzzle.ts 86.20% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Aschen Aschen merged commit fbe40ab into 7-dev Aug 31, 2022
@Aschen Aschen deleted the fix-mappings-property branch August 31, 2022 12:52
@Aschen Aschen mentioned this pull request Sep 2, 2022
Aschen pushed a commit that referenced this pull request Sep 7, 2022
# [7.10.1](https://github.com/kuzzleio/sdk-javascript/releases/tag/7.10.1) (2022-09-02)


#### Bug fixes

- [ [#705](#705) ] Fix the `MappingsProperties` type   ([Aschen](https://github.com/Aschen))
- [ [#701](#701) ] Use PATCH for `document:update` API action using HTTP protocol   ([alexandrebouthinon](https://github.com/alexandrebouthinon))

#### Enhancements

- [ [#704](#704) ] Add support for debug in browser from window object   ([Aschen](https://github.com/Aschen))
- [ [#707](#707) ] Add query typing   ([Aschen](https://github.com/Aschen))
- [ [#699](#699) ] Prevent unhandledRejection from NotificationHandler   ([ChillPC](https://github.com/ChillPC))
---
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants