Skip to content

Commit

Permalink
[ISSUE apache#6511] Refactor var names in MessageStoreConfig
Browse files Browse the repository at this point in the history
  • Loading branch information
kvaithin committed Mar 30, 2023
1 parent 24bc8c9 commit 496252b
Show file tree
Hide file tree
Showing 4 changed files with 26 additions and 26 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -194,9 +194,9 @@ private boolean mmapOperation() {
if (mappedFile.getFileSize() >= this.messageStore.getMessageStoreConfig()
.getMappedFileSizeCommitLog()
&&
this.messageStore.getMessageStoreConfig().isWarmMapedFileEnable()) {
this.messageStore.getMessageStoreConfig().isWarmMappedFileEnable()) {
mappedFile.warmMappedFile(this.messageStore.getMessageStoreConfig().getFlushDiskType(),
this.messageStore.getMessageStoreConfig().getFlushLeastPagesWhenWarmMapedFile());
this.messageStore.getMessageStoreConfig().getFlushLeastPagesWhenWarmMappedFile());
}

req.setMappedFile(mappedFile);
Expand Down
4 changes: 2 additions & 2 deletions store/src/main/java/org/apache/rocketmq/store/CommitLog.java
Original file line number Diff line number Diff line change
Expand Up @@ -900,7 +900,7 @@ public CompletableFuture<PutMessageResult> asyncPutMessage(final MessageExtBroke
log.warn("[NOTIFYME]putMessage in lock cost time(ms)={}, bodyLength={} AppendMessageResult={}", elapsedTimeInLock, msg.getBody().length, result);
}

if (null != unlockMappedFile && this.defaultMessageStore.getMessageStoreConfig().isWarmMapedFileEnable()) {
if (null != unlockMappedFile && this.defaultMessageStore.getMessageStoreConfig().isWarmMappedFileEnable()) {
this.defaultMessageStore.unlockMappedFile(unlockMappedFile);
}

Expand Down Expand Up @@ -1049,7 +1049,7 @@ public CompletableFuture<PutMessageResult> asyncPutMessages(final MessageExtBatc
log.warn("[NOTIFYME]putMessages in lock cost time(ms)={}, bodyLength={} AppendMessageResult={}", elapsedTimeInLock, messageExtBatch.getBody().length, result);
}

if (null != unlockMappedFile && this.defaultMessageStore.getMessageStoreConfig().isWarmMapedFileEnable()) {
if (null != unlockMappedFile && this.defaultMessageStore.getMessageStoreConfig().isWarmMappedFileEnable()) {
this.defaultMessageStore.unlockMappedFile(unlockMappedFile);
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2172,7 +2172,7 @@ private void deleteExpiredFiles() {
int deleteCount = 0;
long fileReservedTime = DefaultMessageStore.this.getMessageStoreConfig().getFileReservedTime();
int deletePhysicFilesInterval = DefaultMessageStore.this.getMessageStoreConfig().getDeleteCommitLogFilesInterval();
int destroyMappedFileIntervalForcibly = DefaultMessageStore.this.getMessageStoreConfig().getDestroyMapedFileIntervalForcibly();
int destroyMappedFileIntervalForcibly = DefaultMessageStore.this.getMessageStoreConfig().getDestroyMappedFileIntervalForcibly();
int deleteFileBatchMax = DefaultMessageStore.this.getMessageStoreConfig().getDeleteFileBatchMax();

boolean isTimeUp = this.isTimeToDelete();
Expand Down Expand Up @@ -2219,7 +2219,7 @@ private void reDeleteHangedFile() {
if ((currentTimestamp - this.lastRedeleteTimestamp) > interval) {
this.lastRedeleteTimestamp = currentTimestamp;
int destroyMappedFileIntervalForcibly =
DefaultMessageStore.this.getMessageStoreConfig().getDestroyMapedFileIntervalForcibly();
DefaultMessageStore.this.getMessageStoreConfig().getDestroyMappedFileIntervalForcibly();
if (DefaultMessageStore.this.commitLog.retryDeleteFirstFile(destroyMappedFileIntervalForcibly)) {
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ public class MessageStoreConfig {
private int deleteCommitLogFilesInterval = 100;
// ConsumeQueue removal interval
private int deleteConsumeQueueFilesInterval = 100;
private int destroyMapedFileIntervalForcibly = 1000 * 120;
private int destroyMappedFileIntervalForcibly = 1000 * 120;
private int redeleteHangedFileInterval = 1000 * 120;
// When to delete,default is at 4 am
@ImportantField
Expand All @@ -157,7 +157,7 @@ public class MessageStoreConfig {
@ImportantField
private int deleteFileBatchMax = 10;
// Flow control for ConsumeQueue
private int putMsgIndexHightWater = 600000;
private int putMsgIndexHighWater = 600000;
// The maximum size of message body,default is 4M,4M only for body length,not include others.
private int maxMessageSize = 1024 * 1024 * 4;
// Whether check the CRC32 of the records consumed.
Expand All @@ -169,7 +169,7 @@ public class MessageStoreConfig {
// How many pages are to be committed when commit data to file
private int commitCommitLogLeastPages = 4;
// Flush page size when the disk in warming state
private int flushLeastPagesWhenWarmMapedFile = 1024 / 4 * 16;
private int flushLeastPagesWhenWarmMappedFile = 1024 / 4 * 16;
// How many pages are to be flushed when flush ConsumeQueue
private int flushConsumeQueueLeastPages = 2;
private int flushCommitLogThoroughInterval = 1000 * 10;
Expand Down Expand Up @@ -216,7 +216,7 @@ public class MessageStoreConfig {
private long flushDelayOffsetInterval = 1000 * 10;
@ImportantField
private boolean cleanFileForciblyEnable = true;
private boolean warmMapedFileEnable = false;
private boolean warmMappedFileEnable = false;
private boolean offsetCheckInSlave = false;
private boolean debugLockEnable = false;
private boolean duplicationEnable = false;
Expand Down Expand Up @@ -418,12 +418,12 @@ public void setDiskFallRecorded(final boolean diskFallRecorded) {
this.diskFallRecorded = diskFallRecorded;
}

public boolean isWarmMapedFileEnable() {
return warmMapedFileEnable;
public boolean isWarmMappedFileEnable() {
return warmMappedFileEnable;
}

public void setWarmMapedFileEnable(boolean warmMapedFileEnable) {
this.warmMapedFileEnable = warmMapedFileEnable;
public void setWarmMappedFileEnable(boolean warmMappedFileEnable) {
this.warmMappedFileEnable = warmMappedFileEnable;
}

public int getCompactionMappedFileSize() {
Expand Down Expand Up @@ -532,12 +532,12 @@ public void setFlushIntervalConsumeQueue(int flushIntervalConsumeQueue) {
this.flushIntervalConsumeQueue = flushIntervalConsumeQueue;
}

public int getPutMsgIndexHightWater() {
return putMsgIndexHightWater;
public int getPutMsgIndexHighWater() {
return putMsgIndexHighWater;
}

public void setPutMsgIndexHightWater(int putMsgIndexHightWater) {
this.putMsgIndexHightWater = putMsgIndexHightWater;
public void setPutMsgIndexHighWater(int putMsgIndexHighWater) {
this.putMsgIndexHighWater = putMsgIndexHighWater;
}

public int getCleanResourceInterval() {
Expand Down Expand Up @@ -753,12 +753,12 @@ public void setFlushConsumeQueueThoroughInterval(int flushConsumeQueueThoroughIn
this.flushConsumeQueueThoroughInterval = flushConsumeQueueThoroughInterval;
}

public int getDestroyMapedFileIntervalForcibly() {
return destroyMapedFileIntervalForcibly;
public int getDestroyMappedFileIntervalForcibly() {
return destroyMappedFileIntervalForcibly;
}

public void setDestroyMapedFileIntervalForcibly(int destroyMapedFileIntervalForcibly) {
this.destroyMapedFileIntervalForcibly = destroyMapedFileIntervalForcibly;
public void setDestroyMappedFileIntervalForcibly(int destroyMappedFileIntervalForcibly) {
this.destroyMappedFileIntervalForcibly = destroyMappedFileIntervalForcibly;
}

public int getFileReservedTime() {
Expand Down Expand Up @@ -965,12 +965,12 @@ public void setStorePathRootDir(String storePathRootDir) {
this.storePathRootDir = storePathRootDir;
}

public int getFlushLeastPagesWhenWarmMapedFile() {
return flushLeastPagesWhenWarmMapedFile;
public int getFlushLeastPagesWhenWarmMappedFile() {
return flushLeastPagesWhenWarmMappedFile;
}

public void setFlushLeastPagesWhenWarmMapedFile(int flushLeastPagesWhenWarmMapedFile) {
this.flushLeastPagesWhenWarmMapedFile = flushLeastPagesWhenWarmMapedFile;
public void setFlushLeastPagesWhenWarmMappedFile(int flushLeastPagesWhenWarmMappedFile) {
this.flushLeastPagesWhenWarmMappedFile = flushLeastPagesWhenWarmMappedFile;
}

public boolean isOffsetCheckInSlave() {
Expand Down

0 comments on commit 496252b

Please sign in to comment.