Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing required apiVersion field in Chart.yaml #18

Merged
merged 1 commit into from
Jun 22, 2021

Conversation

nktpro
Copy link
Contributor

@nktpro nktpro commented Apr 24, 2021

The apiVersion field is required in Chart.yaml as per Helm documentation. Since it's currently missing, this Helm chart fails validation of some tools.

@nktpro
Copy link
Contributor Author

nktpro commented Jun 22, 2021

@kvaps do you have any comments / concerns regarding this PR? It's been open for a while now...

@kvaps
Copy link
Owner

kvaps commented Jun 22, 2021

Sorry for late answer,
The chart was constructed to be able work with both Helm2 and Helm3 versions. However since now nobody use Helm2 to deploy new releases (I hope), so, let it be merged.

@kvaps kvaps merged commit b92830f into kvaps:master Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants